[#22536] - [4.0] Installer library query fixes
- Fixed in Code Base
- 10 Oct 2018
- Medium
- Build: 4.0-dev
- # 22536
- Diff
- mbabker:installer-fixes
User tests: Successful: Unsuccessful:
Pull Request for Issues #21958 & #22531
Summary of Changes
As it seems nobody else will fix database query related issues, here's the pull request fixing two reported issues with queries in the extension installer library:
- Renames a query parameter since parameter substitution is incorrectly replacing the second parameter
- Adds a missing use statement for a PHP class
Testing Instructions
- Code review
- Attempt to uninstall a component or plugin
Expected result
Operations complete successfully
Actual result
Operations do not complete
Additional Comments
Any other style related fixes or errors are out of scope of this pull request and will not be addressed by me. Far too often unrelated fixes are being requested in pull requests making it easier for pull requests to introduce more changes and newer bugs, changes should be isolated and tested/reviewed separately.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22536.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22536.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-10-10 12:57:01 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
I have tested this item✅ successfully on 5c873d7
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22536.