? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
7 Oct 2018

Summary of Changes

keep track of check-in actions

Testing Instructions

  • Maintenance: Global Check-in
  • Check-in a checked out item

Expected result

screenshot from 2018-10-07 13-12-47

Actual result

not logged

Documentation Changes Required

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
4.00

avatar alikon alikon - open - 7 Oct 2018
avatar alikon alikon - change - 7 Oct 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Oct 2018
Category Administration com_checkin Language & Strings SQL Installation Postgresql MS SQL Libraries Front End Plugins
avatar jsubri
jsubri - comment - 7 Oct 2018

I'm using staging but I can't get it working despite I've inserted manually the row in #_action_logs_extensions. I noticed their is a 2h difference between this PR and committed files in Staging. Are you in sync?

avatar alikon alikon - change - 8 Oct 2018
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 8 Oct 2018
Category Administration com_checkin Language & Strings SQL Installation Postgresql MS SQL Libraries Front End Plugins Administration SQL com_admin com_checkin Language & Strings Installation Postgresql MS SQL Libraries Front End Plugins
avatar alikon
alikon - comment - 8 Oct 2018

the changes requested

avatar jsubri
jsubri - comment - 9 Oct 2018

Not sure what is the practice for things intwined between Beta cycle.
This is difficult to test using patch_tester for Upgraded site that are already to 3.9B4 as this PR need other committed stuff already in staging. Can we have the supplemental files in administrator/components/com_admin... ? e.g not only for fresh install

avatar mbabker
mbabker - comment - 9 Oct 2018

The additions to the #__action_logs_extensions table should be their own SQL files. The changes to the parameter values shouldn't as that changes an existing user configuration (so at most for someone who is already on beta track, they'd just need to go in and re-save the component config adding the new component; keep in mind #21024 has yet to have an "official" response and as such the project does not support upgrades between non-stable releases).

64ef80a 12 Oct 2018 avatar alikon oops
52a5aa2 13 Oct 2018 avatar alikon lang
avatar jsubri
jsubri - comment - 13 Oct 2018

I have tested this item successfully on 52a5aa2

Test ok on upgraded site.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22530.
avatar jsubri jsubri - test_item - 13 Oct 2018 - Tested successfully
avatar jsubri
jsubri - comment - 13 Oct 2018

Note for testers: the below manual actions are required on upgraded site 3.9RC

insert into #__action_logs_extensions values (18, 'com_checkin');
delete from #__extensions where extension_id = 36
insert into #__extensions (extension_id, package_id, name, type, element, folder, client_id, enabled, access, protected, manifest_cache, params, custom_data, system_data, checked_out, checked_out_time, ordering, state) VALUES
(36, 0, 'com_actionlogs', 'component', 'com_actionlogs', '', 1, 1, 1, 1, '', '{"ip_logging":0,"csv_delimiter":",","loggable_extensions":["com_banners","com_cache","com_categories","com_checkin","com_config","com_contact","com_content","com_installer","com_media","com_menus","com_messages","com_modules","com_newsfeeds","com_plugins","com_redirect","com_tags","com_templates","com_users"]}', '', '', 0, '0000-00-00 00:00:00', 0, 0);

screen shot 2018-10-13 at 21 29 24


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22530.

ddbe4a1 16 Oct 2018 avatar alikon oops
avatar jsubri
jsubri - comment - 16 Oct 2018

What about @mbabker suggestion to have
insert into #__action_logs_extensions values (18, 'com_checkin');
In a separated file ?

avatar twister65
twister65 - comment - 8 Jan 2019

After this patch is applied, the tables in the database are not updated.
com_checkin is missing in #__extensions and #__action_logs_extensions tables.

avatar alikon
alikon - comment - 8 Jan 2019

true, this needs some more cares, when it was proposed 3.9 wasn't released yet...
on my todo list

avatar alikon
alikon - comment - 13 Jan 2019

redone with #23526

avatar alikon alikon - change - 13 Jan 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-01-13 09:35:10
Closed_By alikon
avatar alikon alikon - close - 13 Jan 2019

Add a Comment

Login with GitHub to post a comment