But this does not seem initiative to me when it comes to modules. You could edit a module in the header and the editor could appear in the footer. It can be far removed from the place you totally click edit.

It shouldnt do - thats probably a template issue of yours as you probably don't have a component area on that page?

Sorry, I should have added an example to make it clearer.

The component area could be anywhere on the page. In this example, the module is two rows above the editing part. To further compound the matter the page refreshes and takes you to the top, so if the component is further down it can feel a bit like nothing has happened except a refresh.

Usually, there would be some sort of visual hierarchy/direction to tie the two things together. I think a popup would be neatest, but another option would be to open the editing window in the same location as the module. At the moment this is just to see if anyone agrees with me that this is confusing, we can talk about solutions if everyone agrees it's a problem.

I think the only alternative would be a popup/modal.

but another option would be to open the editing window in the same location as the module

It is quite likely that a module position would not be able to contain the current module editor and all it's options.

Agreed. I was really just shooting from the hip. It would be nice if the modal could load without a refresh too, but I'm assuming that's a technical problem we want to avoid for page load time reasons.

Ok all, I have managed to get this to work. My edit article appears in a modal. Is it worth submitting a pull request?

This would certainly solve the issue of edit box appearing only where com_content displays.
Would also concentrate user on edits by reducing noise from rest of page.

I have one issue which I consider to be unacceptable UX. If anyone can help me to understand this then I can finalise and make a pull request. https://joomla.stackexchange.com/questions/23828/why-cant-i-use-a-modal-close-button-in-the-joomla-modal-body

I would really like to see this in j4

I have got the articles editing part working in a modal in J3. I'm still looking for the modules editing part. If anyone can point me in the right direction that would be awesome. I believe we are dropping Bootstrap in J4. If anyone can give me a clue as to what we are using instead that would be good. Will it be a custom library? Is J4 on GitHub? I couldn't find it within the repositories

Now that we have a webservice API in J4, it could also be interesting to use the inline editing feature of TinyMCE (and probably other editors) for editing content of articles or modules.
Then you would only need the full edit form when you want to change parameters, not when you want to change the content.

Wow I was totally unaware of that. But YES that would absolutely be the right way to do things.

I'll have to have a look into things. I have it nearly working on J3. But that wasn't the request. I still think it's an improvement.

Changed Title for J4.

@uglyeoin see #24110 - is this a PR for this Issue?

Thanks @franz-wohlkoenig you might save me some work. I will test it, it may mean that a modal popup is unnecessary. Inline editing would be far better. Let me test the other version and if it is better or the same I'll close this

@franz-wohlkoenig no it turns out it doesn't, so I will try to do a pull request to implement my idea. Thanks for highlighting.

@uglyeoin I hope its ok if I close this now as we do at least have a proof of concept now

@brianteeman does it solve the problem described in this issue? The solution proposed was a modal popup window, which avoided a reload of the page, which was a nice feature, but also ensured any module positions were below the editing window thus no scrolling occurred.

I assume that is not accessible but I think the very best option would be to have inline editing. Perhaps using https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Editable_content and maybe com_ajax.

inline editing of a module would only work for a customhtml module - not for any others

Yes, that much is true. Although, that's not to say we couldn't do it for a custom module, but the article it should be no problem. We would have to consider how they change any other parameters such as unpublished so it requires a bit of thought and a wider conversation. I'm 100% of the thought that users would find this the most intuitive way to edit content.

Perhaps if clicking on edit brought in a top menu etc it could have the options.

inline is great for fixing a typo. for everything else it sucks
my 5p

I've seen it work in quite a few systems really well