? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
6 Oct 2018

Summary of Changes

Loading the class in SITE/components/com_content/models/articles.php

Testing Instructions

Set a multilingual site.
In Global Configuration allow Inline Editing for Modules & Menus
screen shot 2018-10-06 at 12 23 48

Edit Global Options for Articles and set Show associations to Show
screen shot 2018-10-06 at 12 23 05

Make sure you have some articles associated.

EDIT: Display on the page a mod_latest_news module.

Login frontend as super user and edit a module by clicking on the icon

screen shot 2018-10-06 at 12 27 43

Before patch

Protostar in error and Class 'ContentHelperAssociation' not found (this will show if debug is on)

After patch

All OK.

Note: The class is loaded in 4.0

avatar infograf768 infograf768 - open - 6 Oct 2018
avatar infograf768 infograf768 - change - 6 Oct 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Oct 2018
Category Front End com_content
avatar infograf768 infograf768 - change - 6 Oct 2018
The description was changed
avatar infograf768 infograf768 - edited - 6 Oct 2018
avatar infograf768
infograf768 - comment - 8 Oct 2018

Folks, this is quite similar to #22525 in the sense that the issue happens only when editing a module in frontend.

avatar jsubri
jsubri - comment - 8 Oct 2018

I was not able yet to reproduce with a custom template. Can you indicate if the problem occurs with J3.9 Beta 4 or staging?

avatar infograf768
infograf768 - comment - 8 Oct 2018

please test with protostar. page would display fo rexample a blog with these associated articles.

avatar csthomas
csthomas - comment - 8 Oct 2018

Class ContentHelperAssociation in registered in components/com_content/content.php but modules (latest news) does not load this file. They load only components/com_content/models/articles.php.

avatar infograf768
infograf768 - comment - 10 Oct 2018

Indeed, just found this happens when that module is present on the page.

avatar infograf768
infograf768 - comment - 10 Oct 2018

@csthomas
Therefore do you see any other solution than the one proposed in this PR?

avatar infograf768 infograf768 - change - 10 Oct 2018
The description was changed
avatar infograf768 infograf768 - edited - 10 Oct 2018
avatar csthomas
csthomas - comment - 10 Oct 2018

My advice will not help, because I would like to remove the loading associations from the articles.php model and load them only in the views. Because removing associations from the model can be treated as a B/C break, we can not do anything more.

avatar csthomas
csthomas - comment - 10 Oct 2018

There was a solution not to load tags for modules, added by Michael, but for associations it may not work. I suppose the modules like (latest news) do not require any associations.

avatar infograf768
infograf768 - comment - 10 Oct 2018

Indeed, these modules do not need associations.
Therefore, at least for 3.x, this PR is the only solution to keep B/C.
Please set your test OK on issues.joomla.org

@jsubri
Please test again after adding a Latest News module to the page.

avatar csthomas
csthomas - comment - 10 Oct 2018

I have tested this item successfully on 09cb768

To see error I had to set 'Show Associations: Show' in article options.
Use Global (Show) do not work.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22518.

avatar csthomas
csthomas - comment - 10 Oct 2018

I have tested this item successfully on 09cb768

To see error I had to set 'Show Associations: Show' in article options.
Use Global (Show) do not work.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22518.

avatar csthomas csthomas - test_item - 10 Oct 2018 - Tested successfully
avatar mbabker mbabker - close - 10 Oct 2018
avatar mbabker mbabker - merge - 10 Oct 2018
avatar mbabker mbabker - change - 10 Oct 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-10-10 12:00:58
Closed_By mbabker
Labels Added: ?

Add a Comment

Login with GitHub to post a comment