[#22501] - [4.0] [RFC] libraries/cms/html/jgrid.php needs a review
- Closed
- 19 Nov 2018
- Medium
- Build: v4.0 dev
- # 22501
libraries/cms/html/jgrid.php seems to be dammaged. A review should be made to be sure that parameters are correct and consistent.
Some PRS made missing buttons visible again, but the parameters still are not consitent - especially the parameter text.
| Labels |
Added:
?
|
||
I noticed missing icons the day before this issue https://issues.joomla.org/tracker/joomla-cms/22420
At the moment,the ordering column is not working. If I remove the parameter "text" here https://github.com/joomla/joomla-cms/blame/14bfb01821e4b60811f4a306c28f8e00940a6e1e/libraries/cms/html/jgrid.php#L423 and here https://github.com/joomla/joomla-cms/blame/14bfb01821e4b60811f4a306c28f8e00940a6e1e/libraries/cms/html/jgrid.php#L423 it works, but then the parameter text is not used at all.
brianteeman
- | Labels |
Added:
J4 Issue
|
||
Please close this, thank you.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22501.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-11-19 21:39:26 |
| Closed_By | ⇒ | joomla-cms-bot |
Quy
- | Closed_By | joomla-cms-bot | ⇒ | Quy |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/22501
Since when it is damaged?