[#22494] - Links to buttons
- Fixed in Code Base
- 6 Oct 2018
- Medium
- Build: staging
- # 22494
- Diff
- SharkyKZ:buttons3x_2
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This replaces link tags that look and act like buttons with actual buttons. See #20682 for details.
Testing Instructions
Code review.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_categories com_contact com_content com_fields com_menus com_modules com_newsfeeds com_redirect com_tags com_templates com_users |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22494.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22494.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-10-06 18:48:25 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
woohoo
I thought everything that goes into 3.x is supposed to reach 4.0 eventually. I can see a lot of a11y stuff going into 4.0 now. But, IMO, simple markup fixes like this should be done against 3.x too.
you are correct but we have a really big backlog on that and I would really like to get as much a11y stuff done in J4 as quickly as possible. Plus I suspect that a lot of the remaining links->buttons are modal related and we plan to change from a bootstrap modal at some point so it would be good to have them changed now as it will be hard to add later from the 3.x branch
Should this be done for both 3.x and 4.0 then? Or just 4.0?
I have tested this item✅ successfully on 6401c60
Code Review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22494.