?
avatar Harmageddon
Harmageddon
1 Oct 2018

Pull Request for Issue #20210 / replacement PR for #22335 .

Summary of Changes

Fixes the padding and spacing bugs for different window sizes for the repeatable-table layout for subform fields by using a vertical form instead of a horizontal one.
Uses responsive tables displaying the table header in the left column for narrow screens.

Testing Instructions

Please test different subforms with layout="joomla.form.field.subform.repeatable-table", some of them with groupByFieldset="true" and some without it. You can do this by manipulating some module's XML manifest I used the following forms:

<field
	name="entries"
	type="subform"
	formsource="subform"
	multiple="true"
	label="Subform"
	layout="joomla.form.field.subform.repeatable-table"
	groupByFieldset="true"
	min="1"
	>
	<fieldset label="private" name="private">
		<field
			name="num1"
			type="text"
			label="Number 1"
			filter="int"
		/>
		<field
			name="mail1"
			type="text"
			default=""
			label="Mail 1"
			validate="email"
		/>
	</fieldset>
	<fieldset label="office" name="office">
		<field
			name="num2"
			type="text"
			label="Number 2"
			filter="int"
		/>
		<field
			name="mail2"
			type="text"
			default=""
			label="Mail 2"
			validate="email"
		/>
	</fieldset>
	<fieldset label="mobile" name="mobile">
		<field
			name="num2"
			type="text"
			label="Number 3"
			filter="int"
		/>
		<field
			name="mail2"
			type="text"
			default=""
			label="Mail 3"
			validate="email"
		/>
	</fieldset>
</field>
<field name="subform1" type="subform" label="subform"
	layout="joomla.form.field.subform.repeatable-table" multiple="true"
	groupByFieldset="true" min="1">
	<form>
		<fieldset name="group1" label="group 1">
			<field type="text" name="text" label="text 1"/>
			<field type="text" name="text2" label="text 2"/>
			<field type="text" name="text3" label="text 3"/>
		</fieldset>
		<fieldset name="group2" label="group 2">
			<field type="text" name="text4" label="text 4"/>
			<field type="textarea" name="textarea" label="textarea"/>
		</fieldset>
	</form>
</field>
<field name="subform2" type="subform" label="subform"
	   layout="joomla.form.field.subform.repeatable-table" multiple="true" min="1">
	<form>
		<fieldset name="group1" label="group 1">
			<field type="text" name="text" label="text 1"/>
			<field type="text" name="text2" label="text 2"/>
			<field type="text" name="text3" label="text 3"/>
		</fieldset>
		<fieldset name="group2" label="group 2">
			<field type="text" name="text4" label="text 4"/>
			<field type="textarea" name="textarea" label="textarea"/>
		</fieldset>
	</form>
</field>

Please test this with different screen widths (e.g. with the mobile development tools of the browser of your choice).

Expected result

The fields should always have an appropriate width. The labels should be displayed correctly. On small screens, the table columns should stack and the table headers (either fieldset names for groupByFieldset="true" or field names otherwise) should be displayed in the left column.

avatar Harmageddon Harmageddon - open - 1 Oct 2018
avatar ciar4n
ciar4n - comment - 2 Oct 2018

Tested successfully. For some reason this PR is not listed on the tracker?

Nice job!

avatar Harmageddon Harmageddon - change - 2 Oct 2018
Status New Pending
avatar Harmageddon Harmageddon - change - 2 Oct 2018
Category Templates (admin)
avatar Quy Quy - change - 2 Oct 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 2 Oct 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22444.

avatar mbabker mbabker - change - 3 Oct 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-10-03 12:05:03
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 3 Oct 2018
avatar mbabker mbabker - merge - 3 Oct 2018
avatar joomla-cms-bot joomla-cms-bot - change - 3 Oct 2018
Category Templates (admin) Layout

Add a Comment

Login with GitHub to post a comment