Conflicting Files ?
avatar chmst
chmst
30 Sep 2018

Summary of Changes

This PR makes a lock icon visible if an item is checked-out. Set set of parameters in jgrid is fixed .
It fixes also the ordering column.

Testing Instructions

Go to the backend - articles overview or another list view.
Open an item for editing, close the browser window.
Open the list view in a new session

Expected result

The locked item has a symbol "lock", orderring is possible

fixed-lock

Actual result

The icon is not visible, the ordering column does nothing

missing-lock

Documentation Changes Required

no

avatar chmst chmst - open - 30 Sep 2018
avatar brianteeman
brianteeman - comment - 30 Sep 2018

wasnt this fixed in your other pr?

avatar chmst
chmst - comment - 1 Oct 2018

This is in aonther method. The former PR fixed status icons.

avatar brianteeman
brianteeman - comment - 1 Oct 2018

ah - ok

avatar SharkyKZ
SharkyKZ - comment - 1 Oct 2018

Assuming HTML in tooltips is still allowed, html_entity_decode() should be restored.

avatar chmst
chmst - comment - 1 Oct 2018

@SharkyKZ thank you. The change here and the PR #22424 (comment) at least make the icons visible.
The popovers and toolTips are not in scope of this PR.

avatar dgrammatiko
dgrammatiko - comment - 1 Oct 2018

Assuming HTML in tooltips is still allowed, html_entity_decode() should be restored.

Only focusable elements can have tooltips.-

avatar chmst chmst - change - 5 Oct 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2018
Category Libraries
avatar chmst chmst - change - 5 Oct 2018
Title
[4.0] Make the checked-out icon visible
[4.0] Make the checked-out icon visible, fix ordering column
avatar chmst chmst - edited - 5 Oct 2018
avatar chmst chmst - change - 5 Oct 2018
The description was changed
avatar chmst chmst - edited - 5 Oct 2018
avatar laoneo
laoneo - comment - 18 Oct 2018

Where do we stay here?

avatar chmst
chmst - comment - 19 Nov 2018
avatar chmst chmst - change - 19 Nov 2018
Status New Closed
Closed_Date 0000-00-00 00:00:00 2018-11-19 09:46:08
Closed_By chmst
Labels Added: Conflicting Files
avatar chmst chmst - close - 19 Nov 2018

Add a Comment

Login with GitHub to post a comment