in english it needs the "the"

So, i don't know (yet) how it's possible to translate in French...

You shouldn’t have to provide a literal translation of the English text.
It should be encouraged to use structurally correct statements in the
translated language.

On Fri, Sep 28, 2018 at 6:42 AM Cyril Rezé notifications@github.com wrote:

So, i don't know (yet) how it's possible to translated in French...

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#22426 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfoVyN6tqcE7OBms21ga15R-c5DquTks5ufgszgaJpZM4W-WAh
.

--

• Michael Please pardon any errors, this message was sent from my iPhone.

Maybe this way:

PLG_SYSTEM_ACTIONLOGS_CONTENT_ADDED="{type} <a href=\"{itemlink}\">{title}</a> created by user <a href=\"{accountlink}\">{username}</a>"
PLG_SYSTEM_ACTIONLOGS_CONTENT_ARCHIVED="{type} <a href=\"{itemlink}\">{title}</a> archived by user <a href=\"{accountlink}\">{username}</a>"
etc...

Where {type} will include particle in the string
In file : https://github.com/joomla/joomla-cms/blob/staging/administrator/language/en-GB/en-GB.plg_actionlog_joomla.ini

Having this instead:

PLG_ACTIONLOG_JOOMLA_TYPE_ARTICLE="the article"
PLG_ACTIONLOG_JOOMLA_TYPE_CATEGORY="the category"
etc...

You shouldn’t have to provide a literal translation of the English text. It should be encouraged to use structurally correct statements in the translated language.

Yes, but how to manage {type} for category, article... currently using the default string?

@mbabker ok, so you mean by adding specific strings for other languages not in English, but only if needed :
PLG_SYSTEM_ACTIONLOGS_CATEGORY_UPDATED="L'utilisateur <a href=\"{accountlink}\">{username}</a> a mis à jour la {type} <a href=\"{itemlink}\">{title}</a>"

@JoomliC
We can't add specific strings unless they are plural forms which crowdin takes care of when defined.
I had already chosen a specific formatting for the French Language pack

I have used this:

; Common content type log messages
PLG_SYSTEM_ACTIONLOGS_CONTENT_ADDED="L'utilisateur <a href=\"{accountlink}\">{username}</a> a ajouté : {type}, <a href=\"{itemlink}\">{title}</a>"
PLG_SYSTEM_ACTIONLOGS_CONTENT_ARCHIVED="L'utilisateur <a href=\"{accountlink}\">{username}</a> a archivé : {type}, <a href=\"{itemlink}\">{title}</a>"
PLG_SYSTEM_ACTIONLOGS_CONTENT_UPDATED="L'utilisateur <a href=\"{accountlink}\">{username}</a> a mis à jour : {type}, <a href=\"{itemlink}\">{title}</a>"
PLG_SYSTEM_ACTIONLOGS_CONTENT_PUBLISHED="L'utilisateur <a href=\"{accountlink}\">{username}</a> a publié : {type}, <a href=\"{itemlink}\">{title}</a>"
PLG_SYSTEM_ACTIONLOGS_CONTENT_UNPUBLISHED="L'utilisateur <a href=\"{accountlink}\">{username}</a> a dépublié : {type}, <a href=\"{itemlink}\">{title}</a>"
PLG_SYSTEM_ACTIONLOGS_CONTENT_TRASHED="L'utilisateur <a href=\"{accountlink}\">{username}</a> a mis à la corbeille : {type}, <a href=\"{itemlink}\">{title}</a>"
PLG_SYSTEM_ACTIONLOGS_CONTENT_DELETED="L'utilisateur <a href=\"{accountlink}\">{username}</a> a supprimé : {type}, {title}"

Note: but we could indeed modify this and do

PLG_SYSTEM_ACTIONLOGS_CONTENT_ADDED="L'utilisateur <a href=\"{accountlink}\">{username}</a> a ajouté {type} <a href=\"{itemlink}\">{title}</a>"

and then change the type
to
l'article, la bannière, le niveau d'accès, etc.

Agree about this way, but my concern was about integration with third party extension, using content plugin event onContentAfterSave
Default strings used when thirdparty extension actionlogs plugin is disabled (allow still logs to be processed...)

But if for French, you use one or the other way, it could work with all types i think! ?

@infograf768 Maybe nicer the second way, with particle inside type ?

Closed: as could be managed different way by language.

@mbabker
Are there any chances for these strings to be used by a 3rd party extension where adding the french particle le, la, l' would create problems?
EDIT: I mean in the TYPE strings

If so then they're reusing strings in a context they weren't written for.

OK, thanks.

If so then they're reusing strings in a context they weren't written for.

@mbabker https://github.com/joomla/joomla-cms/blob/staging/plugins/actionlog/joomla/joomla.php#L123

If thirdparty plugin for action logs is unpublished, it will fall back on default strings for logs.
(this is the result i've got if my extension actionlogs config are set in database with string prefix and i disable my plugin).

In all cases, if my plugin is disable, type strings would be missing too...

If so then they're reusing strings in a context they weren't written for.

@mbabker https://github.com/joomla/joomla-cms/blob/staging/plugins/actionlog/joomla/joomla.php#L123

If thirdparty plugin for action logs is unpublished, it will fall back on default strings for logs.

That has nothing to do with third party re-using these strings in another context, which is what the question was about.

Sorry, misread....