? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
27 Sep 2018

Summary of Changes

The useless tooltip has been removed that said "select to sort by this column" on every column
Table caption has been added that includes stating how the table is sorted (screenreader only)
Sort arrows/indicators have been added with meaningful text eg "Sort by title" (screenreader only)
The sort arrows are after the column title to frontload the column name (important for screenreader)
Currently the arrows are font-awesome icons but could be changed to svg if required
aria-sorted attribute added to the TH of the currently sorted column (important for screenreader)

Testing Instructions

This will require a npm install as there are changes to css and js

Notes

The js added to searchtools.js is working but I would appreciate a check by a js expert
The code and implementation has been reviewed by external accessibility experts

a332cdb 3 Sep 2018 avatar brianteeman cs
9776b56 3 Sep 2018 avatar brianteeman cs
50f5e81 4 Sep 2018 avatar brianteeman woof
43c69ea 22 Sep 2018 avatar brianteeman zzz
avatar brianteeman brianteeman - open - 27 Sep 2018
avatar brianteeman brianteeman - change - 27 Sep 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Sep 2018
Category Administration com_associations com_banners com_cache com_categories com_checkin com_contact com_content com_csp com_fields com_finder com_installer com_languages
avatar brianteeman brianteeman - change - 27 Sep 2018
Labels Added: ?
avatar brianteeman
brianteeman - comment - 27 Sep 2018

thanks for helping fix the js @wilsonge

avatar wilsonge wilsonge - change - 27 Sep 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-09-27 20:01:33
Closed_By wilsonge
avatar wilsonge wilsonge - close - 27 Sep 2018
avatar wilsonge wilsonge - merge - 27 Sep 2018
avatar wilsonge
wilsonge - comment - 27 Sep 2018

Looks good to me on review. Thanks!

avatar brianteeman
brianteeman - comment - 27 Sep 2018

Thanks - took a lot to work out the a11y rules for it

Add a Comment

Login with GitHub to post a comment