? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
27 Sep 2018

Pull Request for Issue # .

Summary of Changes

This removes code deprecated in #22288.

Testing Instructions

Code review.

avatar SharkyKZ SharkyKZ - open - 27 Sep 2018
avatar SharkyKZ SharkyKZ - change - 27 Sep 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Sep 2018
Category Administration com_content
avatar laoneo
laoneo - comment - 27 Sep 2018

For consistency, can we deprecate the getAuthors function in 3 too?

avatar SharkyKZ
SharkyKZ - comment - 27 Sep 2018

It was already deprecated in #22288.

avatar laoneo
laoneo - comment - 27 Sep 2018

Ah sorry missed that.

avatar laoneo
laoneo - comment - 28 Sep 2018

I have tested this item ? unsuccessfully on e0b5a86

I'v tested it and the getAuthors function is still used. It is possible to filter the articles in the back end per author.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22401.
avatar laoneo laoneo - test_item - 28 Sep 2018 - Tested unsuccessfully
avatar SharkyKZ
SharkyKZ - comment - 28 Sep 2018

@laoneo this is expected. Author filter is now provided by AuthorField. getAuthors() was used before we had Search Tools.

avatar laoneo
laoneo - comment - 28 Sep 2018

But it is still used in J4. So we can't remove something which crashes on purpose.

avatar SharkyKZ
SharkyKZ - comment - 28 Sep 2018

@laoneo It's not used. Filter form uses AuthorField.

avatar laoneo
laoneo - comment - 28 Sep 2018

I was on the wrong branch. Works ok

avatar laoneo laoneo - change - 28 Sep 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-09-28 08:45:37
Closed_By laoneo
Labels Added: ?
avatar laoneo laoneo - close - 28 Sep 2018
avatar laoneo laoneo - merge - 28 Sep 2018

Add a Comment

Login with GitHub to post a comment