Feeling Lucky
?
?
[#22389] - [action logs] Add action log plugin library class
- Fixed in Code Base
- 6 Oct 2018
- Medium
- Build: staging
- # 22389
- Diff
- Digital-Peak:j3/action/log
User tests: Successful: Unsuccessful:
Summary of Changes
As extension dev, I like to do as less repetitive work as possible. This pr adds a base class extension devs can use to log actions more convenient. For example a plugin can then look like:
JLoader::import('com_actionlogs.libraries.actionlogplugin', JPATH_ADMINISTRATOR . '/components');
class PlgActionlogFoo extends ActionLogPlugin
{
public function onContentAfterSave($context, $item, $isNew)
{
if ($context != 'com_foo.bar')
{
return;
}
$message = array(
'action' => $isNew ? 'add' : 'update',
'type' => 'PLG_ACTIONLOG_FOO_TYPE_BAR',
'id' => $item->id,
'title' => $item->title,
'itemlink' => 'index.php?option=com_foo&task=edit&id=' . $item->id
);
$this->addLog(array($message), 'PLG_ACTIONLOG_FOO_' . $message['action'], $context);
}
}
Additionally it simplifies the default Joomla log plugin.
Testing Instructions
Save an article.
Expected result
An action log is created.
Actual result
An action log is created.
Documentation Changes Required
Document that a base class exists.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Front End Plugins |
| Labels |
Added:
?
|
||
ciar4n
- comment
- 3 Oct 2018
I have tested this item
Action log created after save
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22389.
infograf768
- comment
- 4 Oct 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22389.
infograf768
- comment
- 4 Oct 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22389.
| Status | Pending | ⇒ | Ready to Commit |
infograf768
- comment
- 4 Oct 2018
RTC.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22389.
infograf768
- comment
- 4 Oct 2018
Note:
The plugin uses the list() method which can be confusing depending on the php version.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-10-06 18:55:55 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Done the changes.