? Success

User tests: Successful: Unsuccessful:

avatar oorzaak
oorzaak
26 Sep 2018

In mod_tags_popular.xml I added an extra option to the parameter field order_value. If this option is selected, the module shows the tags in the order as set manually in the Tags component. This can be combined with setting the maximum number of tags in order to create your custom selection (up to the overall maximum of 20). The idea for this functionality comes from a request from a site owner (one of my customers).

Please note that in this case the module does not take into account the "popularity" of the tag. This is exactly as I intended but it may conflict with the idea of the module: showing popular tags. However, the Random option of the module doesn't take that into account either (as a matter of fact, when selecting my cusom option the execution of the module script follows the same 'logical path' through the code as when selecting the Random option).

It might be a good idea to add some instruction about this. Apart from that, I think this offers some nice extra fuctionality and I was surprised at how easy it was to add this.

Please note this is the first pull request I made. If I did something wrong, please tell me.

Pull Request for Issue # .

Summary of Changes

New feature: added an extra option to the Order parameter of the Tags - popular module: manual ordering

Testing Instructions

  • create a module of the type Tags - popular and make sure that is is displayed in the front end.
  • the drop-down select box for the parameter Order should now have one extra option: Ordering.
  • set the Order parameter to Ordering and the Maximum number of Tags to 20.
  • in Components > Tags, create more than one tag, then check in which order they are displayed by the module in the front end.
  • in Components > Tags, manually change the order of the tags (click the icon on top of the left hand column Ordering, then drag the tags up or down the list) and in the front end, check how the new order of the tags is reflected in the module.

Expected result

In the module you should see the tags in the order as manually set. The display is still limited to the number as set in the Maximum tags parameter, so you will be able to manually select the tags to be displayed up to 20 tags and these tags should be in the first 20 positions of the tags list.

Actual result

This is a new feat so there is no actual result.

Documentation Changes Required

This does not take into account the "popularity" of the tag. That is exactly as I intended but it may conflict with the idea of the module: showing popular tags, so it may confuse the users.

However, the Random option of the module doesn't take that into account either (as a matter of fact, when selecting my cusom option the execution of the module script follows the same 'logical path' through the code as when selecting the Random option).

Maybe it would be a good idea to add a comment about this to the parameter description?

avatar oorzaak oorzaak - open - 26 Sep 2018
avatar oorzaak oorzaak - change - 26 Sep 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Sep 2018
Category Modules Front End
avatar oorzaak
oorzaak - comment - 26 Sep 2018

Note: Before I thought of this solution I was thinking about a kind of 'featured tags' idea. That may be more user friendly but it would involve much more programming.

Frits

avatar oorzaak oorzaak - change - 26 Sep 2018
The description was changed
avatar oorzaak oorzaak - edited - 26 Sep 2018
avatar brianteeman
brianteeman - comment - 26 Sep 2018

Thank youu and congratulations on your first pull request.

avatar jurihahn
jurihahn - comment - 27 Sep 2018

I have tested this item successfully on 804be88


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22384.

avatar jurihahn jurihahn - test_item - 27 Sep 2018 - Tested successfully
avatar viocassel
viocassel - comment - 27 Jan 2019

I have tested this item successfully on 804be88


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22384.

avatar viocassel viocassel - test_item - 27 Jan 2019 - Tested successfully
avatar oorzaak
oorzaak - comment - 4 Feb 2019

Thanks for testing :-)

avatar Quy Quy - change - 4 Feb 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 4 Feb 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22384.

avatar HLeithner
HLeithner - comment - 5 Jun 2019

Because this is a new feature it will not go in to 3.9, please create a new PR for Joomla! 4.0

avatar HLeithner HLeithner - change - 5 Jun 2019
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2019-06-05 17:04:16
Closed_By HLeithner
avatar HLeithner HLeithner - close - 5 Jun 2019

Add a Comment

Login with GitHub to post a comment