Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#22378] - [4.0] Remove the deprecated code in the Access class

? ? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
26 Sep 2018

Remove the deprecated code in the Access class.

avatar laoneo laoneo - open - 26 Sep 2018
avatar laoneo laoneo - change - 26 Sep 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Sep 2018
Category ⇒ Libraries
avatar laoneo laoneo - change - 26 Sep 2018
Labels Added: ? ?
avatar csthomas
csthomas - comment - 26 Sep 2018

There is also a note on line 527.
https://github.com/joomla/joomla-cms/pull/22378/files#diff-692418595f0dc6797e5669cbc3b3870cL527

It will be more difficult.

* @note    The non preloading code will be removed in 4.0. All asset rules should use asset preloading.
avatar laoneo
laoneo - comment - 26 Sep 2018

Means, the preload property code should get removed?

avatar csthomas
csthomas - comment - 26 Sep 2018

IMO preload argument in method and the code when preload is false. But it is risky:)

avatar laoneo
laoneo - comment - 26 Sep 2018

Then better to do it in an isolated pr.

avatar wilsonge wilsonge - change - 30 Sep 2018
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-09-30 11:42:38
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 30 Sep 2018
avatar wilsonge wilsonge - merge - 30 Sep 2018
avatar wilsonge
wilsonge - comment - 30 Sep 2018

Thanks!

avatar infograf768
infograf768 - comment - 6 Oct 2018

@laoneo @wilsonge
I think this has killed the display of permissions for the components.

Basically $xpath is not working.

avatar brianteeman
brianteeman - comment - 15 Oct 2018

@laoneo @wilsonge this has killed the permissions!!

avatar laoneo
laoneo - comment - 16 Oct 2018

Please test #22665 which should fix the rules field.

Add a Comment

Login with GitHub to post a comment