[#22370] - Allow for more fluid .modal-body class
- Closed
- 27 Aug 2019
- Medium
- Build: staging
- # 22370
- Diff
- N6REJ:22332
- Success Hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #22332
Summary of Changes
removed max-height limits for .modal-body content.
Testing Instructions
go to template manager and click on beez 3 template preview image.
Using the element inspector change height of the image to 500px;
Contents will overflow...
Expected result
now modal resizes to keep contents visible.
Actual result
Documentation Changes Required
ios js fix for max-height may need to be adjusted as well.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) Front End Templates (site) |
Just a reminder, this needs to be merged before it's too late.
Can someone please explain the Difference between the 3 Screenshots?
sorry for delay, I'll run thru this on thursday
This PR expands the modal window to fit the template preview and shows scrollbar if taller than the modal window.
This change effects all modal windows in the backend, so we need to check more (all) of them.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-08-27 01:09:23 |
| Closed_By | ⇒ | N6REJ |
I have tested this item✅ successfully on 85ae5b6
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22370.