[#22365] - Changing hardcoded text to language string in template preview
- Fixed in Code Base
- 25 Sep 2018
- Medium
- Build: staging
- # 22365
- Diff
- infograf768:preview_template
User tests: Successful: Unsuccessful:
Pull Request for Issue #22304
Summary of Changes
As title says
Testing Instructions
Allow Preview template in Templates General Options.
Preview template to display the modules positions.
After patching, change the site en-GB.ini new strings values to reflect the fact that Position: and Style: are no more harcoded
New strings are
JGLOBAL_PREVIEW_POSITION="Position: "
JGLOBAL_PREVIEW_STYLE="Style: "
Verify that you still get:
Note: No need to test in RTL. I did it. To test it in RTL, it is not enough to set en-GB to rtl. One has to use a RTL string value containing a :
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Language & Strings Front End Templates (site) |
Use language variables?
I do not understand your question
Add variable (%s) to string for style/position and use JText::sprintf()? Just a suggestion.
Is it possible to remove the space from the string and have a space in the markup?
good suggestion. On it.
| Labels |
Added:
?
?
|
||
That should be it now.
But now to keep the intended styling <span> has to be inside the string
JGLOBAL_PREVIEW_POSITION="<span>Position:</span> %s"
JGLOBAL_PREVIEW_STYLE="<span>Style:</span> %s"
grrr
have to cook now, will see later
Done. Can be tested.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22365.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22365.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22365.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-25 23:30:05 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Use language variables?