[#22351] - Change param show_search_form of com_finder
- Closed
- 15 May 2019
- Medium
- Build: staging
- # 22351
- Diff
- continga:com_finder-showsearchform
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
This commit adds the possibility to edit the show_search_form parameter of the com_finder component.
Summary of Changes
That parameter is actually being already in current (and past) versions, see
- but there was no possibility present to set this parameter to a value.Usage of that parameter was introduced way back with baa5093 but already there you could not set this parameter to a value. This commit fixes this.
Testing Instructions
Apply the patch, set the parameter to a value (either 'Show' or 'Hide'), either in the global component configuration, or when creating/editing a menulink to the com_finder component. Then check whether the search form is shown or not.
Expected result
Depending on the parameter, the search form will be shown or not.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder Language & Strings Front End |
| Labels |
Added:
?
?
|
||
Don't you need to set the new defaults in the install and update SQL?
Don't you need to set the new defaults in the install and update SQL?
No on update SQLs, and as long as we aren't storing a default for the component params in the install SQLs and the PHP code matches the XML form default values then we're good with where everything's at.
Yep, as @mbabker said, we don't need it, as the components install doesn't store anything about it, see
joomla-cms/installation/sql/mysql/joomla.sql
Line 520 in 566a79f
and the php code matches the XML default value (see OP).
once again the question, can we maybe get this merged without the usual "2 tests till RTC"-thing? I don't think we will ever get 2 tests for this... That option has been missing from core since 2011, and I don't think anyone really cares if it is added... so can we just merge it, it should be pretty safe to add it?
calling @Hackwar for com_finder and @HLeithner as Release Lead 3.9
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22351.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22351.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22351.
| Category | Administration com_finder Language & Strings Front End | ⇒ | Administration com_finder Front End |
Any chance to get this merged? Who do I need to poke? ;)
@HLeithner is the man
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-15 07:57:03 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Removed:
J3 Issue
|
||
| Category | Administration com_finder Front End | ⇒ | Administration com_finder Language & Strings Front End |
Can we get this straight-forward change merged without the usual 2 tests till RTC thing? I don't think we will ever get 2 tests for this... That option has been missing from core since 2011, and I don't think anyone really cares if it is added... so can we just merge it, should be safe?