? Pending

User tests: Successful: Unsuccessful:

avatar joeforjoomla
joeforjoomla
24 Sep 2018

Summary of Changes

The $text parameter of the 'action' function in the class JHtmlGrid has been removed:
$text An optional text to display [unused - @deprecated 4.0]

however the functions orderUp and orderDown are still calling the 'action' function with the wrong parameter count.

Expected result

All works as before when using orderUp and orderDown

Actual result

The icons are not rendered because the parameters are mismatching

Documentation Changes Required

avatar joeforjoomla joeforjoomla - open - 24 Sep 2018
avatar joeforjoomla joeforjoomla - change - 24 Sep 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Sep 2018
Category Libraries
avatar joeforjoomla joeforjoomla - change - 24 Sep 2018
Title
Fix jgrid.php to match correct parameters count
[4.0] Fix jgrid.php to match correct parameters count
avatar joeforjoomla joeforjoomla - edited - 24 Sep 2018
avatar wilsonge
wilsonge - comment - 24 Sep 2018

Thanks!

avatar wilsonge wilsonge - change - 24 Sep 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-09-24 10:27:13
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 24 Sep 2018
avatar wilsonge wilsonge - merge - 24 Sep 2018
avatar wilsonge
wilsonge - comment - 24 Sep 2018

Sorry reverted this because you've made it against staging instead of 4.0 - can you do it against the 4.0 branch please

avatar joeforjoomla
joeforjoomla - comment - 24 Sep 2018

Sorry! Created a new one against 4.0 #22349

Add a Comment

Login with GitHub to post a comment