[#22345] - Create and apply 'dropdown-reverse' css class
- Fixed in Code Base
- 2 Oct 2018
- Medium
- Build: staging
- # 22345
- Diff
- ciar4n:dropdown-left
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Creates a dropdown-reverse class to align dropdowns left instead of right. Applies this class to com-menus -> menus.
Simple class which will only work for one level of child items.
Testing Instructions
Apply and navigate to Menu Manager
Before
After
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus Templates (admin) |
| Labels |
Added:
?
|
||
I think the correct way to resolve this is using the bootstrap dropdown and associated popper js - this is what we already use in the save button https://github.com/joomla/joomla-cms/pull/22015/files
We should avoid (if possible) ever having markup that says left which is actually right because of the css
Considering the RTL issue, I was gonna suggest wording something like dropdown-reverse. But yes, if this has already been dealt with in a different way then let's go with that.
This dropdown does not appear to use popper.js ?
popper.js isn't used in BS2 I thought?
bubbles I didnt realise that it was new in bs4
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22345.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22345.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22345.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-10-02 16:12:54 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Now it is an issue with RTL.