[#22335] - Fix subform.repeatable-table small screen padding
- Closed
- 2 Oct 2018
- Medium
- Build: staging
- # 22335
- Diff
- ciar4n:subform-table-responsive
User tests: Successful: Unsuccessful:
Pull Request for Issue #20210 .
Summary of Changes
Fix subform.repeatable-table small screen padding
Testing Instructions
Add the following after https://github.com/joomla/joomla-cms/blob/staging/modules/mod_login/mod_login.xml#L26
Open login module settings. Check repeatable field styling on reduced browser width.
<field name="sebform1" type="subform" label="subform"
layout="joomla.form.field.subform.repeatable-table" multiple="true" groupByFieldset="true">
<form>
<fieldset name="group1" label="group 1">
<field type="text" name="text" label="text 1"/>
<field type="text" name="text2" label="text 2"/>
<field type="text" name="text3" label="text 3"/>
</fieldset>
<fieldset name="group2" label="group 2">
<field type="text" name="text4" label="text 4"/>
<field type="textarea" name="textarea" label="textarea"/>
</fieldset>
</form>
</field>
Before
After
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
I see the problem, but I'm not sure this PR solves it 100%. For example, look at this screenshot taken at a width of 1200px with this PR applied. Some of the inputs are already extremely narrow, and the table collides with the right column.
A simple solution for this would be to use the form-vertical class for this layout, that would lead to displaying the labels above the inputs instead of next to them.
Pro: Solves the problem of small inputs for all screen sizes. One might even consider dropping some of the media queries used right now.
Contra: Changes the look of this layout, leading to a small waste of space, but only on wide screens and in case the table has only one column.
@Harmageddon I agree. What you are suggesting makes far more sense. Do you wish to submit a PR and I can close this?
@ciar4n I just tested only adding form-vertical to the layout in staging, but then, the media query in _forms.less changes the layout again, so I'll have to take some time to look more into the meaning and history of this media query to avoid breaking anything. I probably won't have enough time during the weekend, but can do it on Monday. If you'd like to have this fixed before, feel free to do so. ;-)
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-10-02 07:49:16 |
| Closed_By | ⇒ | ciar4n | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on e3a6cba
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22335.