[#22332] - Allow for more fluid .modal-body class
- Closed
- 25 Sep 2018
- Medium
- Build: staging
- # 22332
- Diff
- N6REJ:modal-body
User tests: Successful: Unsuccessful:
Pull Request for Issue #22331 22331 .
Summary of Changes
removed max-height limits for .modal-body content.
Testing Instructions
go to template manager and click on beez 3 template preview image.
Using the element inspector change height of the image to 500px;
Contents will overflow...
Expected result
now modal resizes to keep contents visible.
Actual result
Documentation Changes Required
ios js fix for max-height may need to be adjusted as well.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) External Library Libraries Composer Change Front End Templates (site) |
| Title |
|
||||||
There are also a lot of unrelated files being committed here that should not be
There are also a lot of unrelated files being committed here that should not be
where? There are 6 .css files involved.
EDIT: WTH!... i'll try to fix that too. Just fyi, idky those files are there they were never touched.
There is some compatibility issues using
display: contents... https://caniuse.com/#feat=css-display-contents
I'll look into that.
| Labels |
Added:
?
?
|
||
@brianteeman here's the changes I pushed.
modal-body.txt
They didnt magically get added
Those may be the changes you made but the other files are in your branch which is why they show up here
@brianteeman I don't dispute that but they don't show in the committ's in netbeans nor do I know how to remove them.
closing this to redo the pr.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-25 16:35:22 |
| Closed_By | ⇒ | N6REJ |
There is some compatibility issues using
display: contents... https://caniuse.com/#feat=css-display-contents