? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
22 Sep 2018

Summary of Changes

Add icons to conditions - similiar to #22315

stages-after

Note: This is pure decoration, therefore the icons are hidden for screenreaders (aria-hidden="true") and do not need information sr-only.

Testing Instructions

Compare an overview of workflow stages before and after patch

Expected result

Every condition has it's respective icon.

Actual result

Conditions are only text.

Documentation Changes Required

lyout has changed

avatar chmst chmst - open - 22 Sep 2018
avatar chmst chmst - change - 22 Sep 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Sep 2018
Category Administration com_workflow
avatar chmst chmst - change - 22 Sep 2018
Title
Add icons to conditions
[4.0] Add icons to conditions
avatar chmst chmst - edited - 22 Sep 2018
avatar chmst chmst - change - 22 Sep 2018
Title
[4.0] Add icons to conditions
[4.0] Add icons to conditions in workflow-stages
avatar chmst chmst - edited - 22 Sep 2018
avatar brianteeman
brianteeman - comment - 22 Sep 2018

I have tested this item successfully on 22803bc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22326.

avatar brianteeman brianteeman - test_item - 22 Sep 2018 - Tested successfully
avatar ReLater
ReLater - comment - 22 Sep 2018

I have tested this item successfully on 22803bc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22326.

avatar ReLater ReLater - test_item - 22 Sep 2018 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 22 Sep 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 22 Sep 2018

Ready to Commit after two successful tests.

avatar wilsonge wilsonge - change - 23 Sep 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-09-23 09:58:48
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 23 Sep 2018
avatar wilsonge wilsonge - merge - 23 Sep 2018

Add a Comment

Login with GitHub to post a comment