[#22319] - Show the full sub-tree of menu-items when filtering by a parent menu item, while respecting the max levels filter
- Fixed in Code Base
- 22 Sep 2018
- Medium
- Build: staging
- # 22319
- Diff
- ggppdk:show_menu_items_subtree
User tests: Successful: Unsuccessful:
Pull Request for Issue #22271
Summary of Changes
This PR allows to see the full sub-tree of menu items when you filter by a specific parent menu item
Also the max levels filter is respected
e.g. to view only the direct children of the parent menu item, user can select a (max) level of "1"
Testing Instructions
- Go to menu items manager
- Filter by a specific menu item (please choose a menu item that has a subtree with 2 or more levels)
Expected result
You see the full sub-tree of menu items
Actual result
You see only the direct children (1st level descedants)
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22319.
Works as follows:
- No filter on max. levels => Full tree shown for selected parent menu.
- Filter on max. levels = n => Tree shown for max. n-1 levels of the selected parent menu (including the parent, i.e. n=2 is like old behavior without this PR).
@ggppdk Question: Is that expected, n=2 shows 1 level because parent is counted in levels but not shown in result?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22319.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
the result that you are getting is strange
the parent menu item (aka the root of the sub-tree) is supposed to be (depth) level 0
and anyway it is not be visible with current code
when we filter by max-level 1 , we get children (=direct descendants only), aka the old behavior
when we filter by max-level 2 , we get children , and grandchildren, menu item items
can you do a rebuild, and then also make sure you have latest version of this branch and retest ?
thanks for re-testing and confirmation
I think you were testing with code getting that was having this effect
#22322 (comment)
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-22 15:01:33 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 59c1c9d
Great thanks @ggppdk works well. Sorry for my oversight when implementing this feature originally.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22319.