[#22315] - [4.0] Improve layout of transitions overview
- Closed
- 23 Sep 2018
- Medium
- Build: 4.0-dev
- # 22315
- Diff
- chmst:workflow-transitions-layout
User tests: Successful: Unsuccessful:
Summary of Changes
Improve the transitons view by adding the icon for the respective condition to every stage.
After Patch
Testing Instructions
Compare the view transition before and after patch.
Actual result
Documentation Changes Required
yes, layout has changed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration com_workflow Language & Strings |
| Title |
|
||||||
| Labels |
Added:
?
?
|
||
| Category | Administration com_workflow Language & Strings | ⇒ | Administration com_workflow |
Thank you @brianteeman , good idea.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22315.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22315.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
| Labels |
Added:
?
Removed: ? |
||
| Category | Administration com_workflow | ⇒ | Administration com_associations com_banners com_categories com_contact com_content com_contenthistory com_finder com_languages com_menus com_newsfeeds com_users |
@franz-wohlkoenig Please remove RTC label temporally - see my previous comment.
sorry, I cannot revert the commot need help someone for help. I do it asap
No, you still have 50 files changed. This should fix the issue:
git checkout -b workflow-transitions-layout-backup #create local backup branch and switch to it.
git checkout workflow-transitions-layout # switch back to This PR branch.
git reset --hard 3de041e27864e96edeea9d90e724c1c6777a91d6 # reset PR to good state.
git push <your-remote-name> -f # push changes to github - replace <your-remote-name> with your joomla fork remote name. This can be checked with git remote -vv
Then we are at Fix quotes, Use existing language strings commit and then only conflicts neds to to be fixed.
Could I delete this branch? It is simpler to make a new one - it is not much code.
You can - this will close this PR, If you create new branch with the same name then you should have reopen option on bottom of comment form on github..
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-23 18:53:12 |
| Closed_By | ⇒ | franz-wohlkoenig |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/22315
Closed as stated in #22343 by @chmst.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22315.
I know it is shorter but it doesn't make sense to me and would be better as
The condition of items at this stage is published
So you can perhaps reuse existing string
COM_WORKFLOW_CONDITION . JPUBLISHED