Feeling Lucky
?
[#22313] - [3.9] Empty lines in log, non functional defer option
- Fixed in Code Base
- 22 Sep 2018
- Medium
- Build: staging
- # 22313
- Diff
- n3t:FormattedtextLogger
User tests: Successful: Unsuccessful:
Summary of Changes
formatLine() function should return formatted text, not write it to file.
Testing Instructions
Open Joomla 3.9 beta 3 site, and try few times invalid login. Then go to your logs dir, and see the error.log.
Expected result
Every attempt should be on single line.
Actual result
Every attempt is followed by an empty line.
Apply the patch and try few invalid logins again, see the log again.
Side effects
As side effect this PR also makes new defer option really functional. As formatLine() function did not return the value, but writes it directly to file, the file was opened multiple times, not once as desired.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
Quy
- comment
- 22 Sep 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22313.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 22 Sep 2018
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22313.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-22 15:18:05 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 8b04d2e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22313.