User tests: Successful: Unsuccessful:
The same as #2206, but during an update to fix it for existing sites.
It should only change the value of the bootstrap_size
when it's set to 1 and leave all other options untouched and only change it for the two modules affected. Thus nothing should break for existing sites.
Please especially have a look at the sqlazure commands as I'm not familiar with that database.
@mbabker I tried to search for sqlazure
, update
and replace
but Google only showed links to update or replace an server so. I guess I need to find the right keywords first to get to the doc.
PostgreSQL is not needed because the bootstrap_size
isn't set in the sample data here. So we don't have this issue here.
The actual server type is SQL Server. SQL Azure is a sub-product running it actually. I don't quite remember why we standardized on sqlazure instead of sqlsrv, but it's whatever at this point.
Anyways, this page might help some - http://technet.microsoft.com/en-us/library/ms177523.aspx
From what I understand from the documentation and from the other examples in our SQL files, it should work.
Is there something like XAMP but with an SQL server? I found Webmatrix but didn't get a database connection yet.
I've not found anything. For the most part, getting XAMPP to work with SQL Server 2008 Express is as easy as downloading the server (express version is free), downloading the PHP drivers and adding them to XAMPP, and adding the relevant lines in php.ini. I went through that setup last weekend on a VM I set up to replace my dead Windows desktop but I'm getting an unrelated DLL error starting XAMPP's Apache with those drivers enabled.
Will do that then. Thanks
What if people have added other modules to that position?
@elinw The SQL only targets the entries with the id 3 and 4, which always are those two modules.
It will not change anything for other modules and it will not change anything other than this particular setting and only if it's currently set to '1'.
SQL query here for easier reading:
UPDATE `#__modules`
SET `params` = REPLACE(`params`, '"bootstrap_size":"1"', '"bootstrap_size":"0"')
WHERE `id` IN (3,4);
Updated with master
Great! Thanks Thomas!
What are the testing instructions? I might be able to test this one out. However, I have a concern that this isn't testable yet, as "Update" SQL commands do not currently work with the database fix function. See:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32332&start=75
Testinstructions are indeed a bit tricky I think. Best I can come up with:
1. Install Joomla 3.1.x with the default sample data.
2. Update to Joomla 3.2beta.
3. Check cPanel and see that the two modules recent and popular articles are broken in display
4. Apply the SQL query from the PR manually (see 3 comments above).
5. The two modules should display fine again.
2.Update to Joomla 3.2beta
This should run the UPDATE in 3.2.0.sql, so no need to apply the UPDATE manually. Unless you are using the manual update.
4.Apply the SQL query from the PR manually (see 3 comments above).
Ran the UPDATE statement against MSSQL 2012 in Server Management Studio. It works as expected.
Thanks Thomas! The pull request is out-of-sync with master. Could you update it?
Sovainfo, for #2, the issue is that this specific UPDATE command is not in beta; that's why this patch is needed. Perhaps I'm misunderstanding you though and some clarification is needed.
Thanks guys!
Merged master and solved conflicts
@nicksavov My bad, you are right. Thank you.
According to this comment: #2348 (comment), this PR #2231 has a bug (i.e. the query isn't executed), which needs to be fixed.
The #2348 is only a workaround.
As written in Elins PR I have no clue what would be wrong with this PR. It works fine for me.
For SQL Server, your best bet is to search the relevant functions in Microsoft's documentation (I do it all too often). You'll also need the same for PostgreSQL.