[#22285] - [com_privacy] xml header encoding utf-8
- Fixed in Code Base
- 22 Sep 2018
- Medium
- Build: staging
- # 22285
- Diff
- alikon:patch-109
User tests: Successful: Unsuccessful:
Pull Request for Issue .
#22240 (comment)
Summary of Changes
added utf-8 encoding to the xml header
Testing Instructions
submit a export data privacy request
confirm the request
Privacy: Information Requests
export the confirmed export data request
open the xml
Expected result
<?xml version="1.0" encoding="utf-8"?>
<data-export>
<domain name="users" description="Joomla! users table data">
<item id="385">
....
Actual result
<?xml version="1.0" ?>Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
I have tested this item
on review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22285.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22285.
According to msdn this is not necessary
https://msdn.microsoft.com/en-us/library/ms256048(v=vs.110).aspx
Encoding Declaration
The encoding declaration identifies which encoding is used to represent the characters in the document. Although XML parsers can determine automatically if a document uses the UTF-8 or UTF-16 Unicode encoding, this declaration should be used in documents that support other encodings.
Better safe than sorry here. Most of the XML is based on database content, unless we can be 100% certain that every export is going to only contain UTF-8 or UTF-16 encoded data this isn't harming anything.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-22 15:02:20 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
?
|
||
I have tested this item✅ successfully on 904a1a6
?
Tested, and works successfully!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22285.