? ? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
20 Sep 2018
  • Adds a deprecated message to the BaseController::getInstance function and deprecates it for 5.
  • Adds a deprecated message to the BaseDatabaseModel::getInstance function and deprecates it for 5.
avatar laoneo laoneo - open - 20 Sep 2018
avatar laoneo laoneo - change - 20 Sep 2018
Status New Pending
avatar laoneo laoneo - change - 20 Sep 2018
Title
[4.0] Adds deprecated messages to the getInstance functions for the model a
[4.0] Adds deprecated messages to the getInstance functions for the model and controller
avatar laoneo laoneo - edited - 20 Sep 2018
avatar joomla-cms-bot joomla-cms-bot - change - 20 Sep 2018
Category Libraries
avatar mbabker
mbabker - comment - 20 Sep 2018

Please add inline JLog or @trigger_error() calls as well so these get logged.

avatar laoneo laoneo - change - 21 Sep 2018
Labels Added: ?
avatar laoneo
laoneo - comment - 21 Sep 2018

Added

avatar brianteeman
brianteeman - comment - 21 Sep 2018

As this is changing the deprecated from 4 to 5 shouldnt the deprecated notice in staging be updated as well

avatar laoneo
laoneo - comment - 24 Sep 2018

Not before 3.10 as we don't have the factory available in staging yet. But we need to discus the backporting anyway as with the DI and service locator story things became a bit different.

avatar wilsonge wilsonge - change - 1 Oct 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-10-01 22:43:34
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 1 Oct 2018
avatar wilsonge wilsonge - merge - 1 Oct 2018
avatar wilsonge
wilsonge - comment - 1 Oct 2018

We should change the notice from 4 to 5 in staging, whether people can transition from 3.10 or not

Add a Comment

Login with GitHub to post a comment