Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#22277] - [com_admin] Simplify profile form layout. Fixes #22262

? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
20 Sep 2018

Pull Request for Issue #22262 .

Summary of Changes

Use FormField::renderField() to render individual fields and JLayout to render fieldsets. Fixes the issue of showon attribute not working.

Testing Instructions

  1. Test that form data is saved properly like before.
  2. Add showon attribute to some fields in /administrator/com_admin/models/forms/profile.xml. Test whether it works.

Expected result

  1. showon works.

Actual result

  1. showon doesn't work.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 20 Sep 2018
avatar SharkyKZ SharkyKZ - change - 20 Sep 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Sep 2018
Category ⇒ Administration com_admin
avatar Quy
Quy - comment - 20 Sep 2018

I have tested this item ✅ successfully on 92069db

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22277.

avatar Quy Quy - test_item - 20 Sep 2018 - Tested successfully
avatar ReLater
ReLater - comment - 20 Sep 2018

I have tested this item ✅ successfully on 92069db

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22277.

avatar ReLater ReLater - test_item - 20 Sep 2018 - Tested successfully
avatar Quy Quy - change - 20 Sep 2018
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 20 Sep 2018

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22277.

avatar mbabker mbabker - change - 22 Sep 2018
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-09-22 15:02:51
Closed_By ⇒ mbabker
Labels Added: ?
avatar mbabker mbabker - close - 22 Sep 2018
avatar mbabker mbabker - merge - 22 Sep 2018

Add a Comment

Login with GitHub to post a comment