? ? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
20 Sep 2018

Pull Request for Issue # .

Summary of Changes

General styling. Most notable difference is moving positioning from absolute to relative.

Testing Instructions

Open frontend with module position preview... https://docs.joomla.org/Finding_module_positions_on_any_given_page

Before

image

After

image

Documentation Changes Required

avatar ciar4n ciar4n - open - 20 Sep 2018
avatar ciar4n ciar4n - change - 20 Sep 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Sep 2018
Category Front End Templates (site)
avatar brianteeman
brianteeman - comment - 20 Sep 2018

Before this pr the module preview would display the position even if it is not active on the page. From your screenshot it looks like you had to create a module in order for it to show. ??

This is much more readable but personally I miss the outline of the position

avatar ciar4n
ciar4n - comment - 20 Sep 2018

Nothing has really changed except the styling. Previously when the module was not published, the module position was also echoed as module content. It was not visible because it was covered by the module details (position and style).

I can add back in the outline. My reasoning for removing the outline was that the module width should be evident by the width of the details block. The height equally evident by the following module position.

avatar brianteeman
brianteeman - comment - 20 Sep 2018

I have found the module outline is useful when the template hardcodes something. For example some templates hardcode the search but keep a module nearby

avatar ciar4n
ciar4n - comment - 20 Sep 2018

Something like this suitable?...

image

avatar brianteeman
brianteeman - comment - 20 Sep 2018

This is the extra text I was referring to. It is confusing because it is shown only if the module position is empty

home

I understand that it was there before and that you couldnt see it - but now that you can see it, it looks confusing

avatar brianteeman
brianteeman - comment - 20 Sep 2018

Just saw your new screenshot. Is the styling your own or the default styling for that position?

avatar ciar4n ciar4n - change - 20 Sep 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 20 Sep 2018
Category Front End Templates (site) Libraries Front End Templates (site)
avatar ciar4n
ciar4n - comment - 20 Sep 2018

I have removed the content = position if the module is not published. Kittens die when I start diving to deep in to php so might be a good idea if someone could double check that commit.

avatar brianteeman
brianteeman - comment - 20 Sep 2018

Thanks - looks much better without the module name visible

avatar ciar4n
ciar4n - comment - 20 Sep 2018

That styling would be separate to the module styling. Similar to the previous outline.

avatar brianteeman
brianteeman - comment - 20 Sep 2018

That would be great then - thank you

avatar ciar4n
ciar4n - comment - 20 Sep 2018

Module outline added as seen in previous screenshot

avatar brianteeman
brianteeman - comment - 20 Sep 2018

I have tested this item successfully on 6efa100


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22272.

avatar brianteeman
brianteeman - comment - 20 Sep 2018

I have tested this item successfully on 6efa100


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22272.

avatar brianteeman brianteeman - test_item - 20 Sep 2018 - Tested successfully
avatar Quy
Quy - comment - 20 Sep 2018

I have tested this item successfully on 6efa100


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22272.

avatar Quy Quy - test_item - 20 Sep 2018 - Tested successfully
avatar Quy Quy - change - 20 Sep 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 20 Sep 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22272.

avatar mbabker mbabker - close - 22 Sep 2018
avatar mbabker mbabker - merge - 22 Sep 2018
avatar mbabker mbabker - change - 22 Sep 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-09-22 15:05:20
Closed_By mbabker
Labels Added: ?

Add a Comment

Login with GitHub to post a comment