? Pending

User tests: Successful: Unsuccessful:

avatar twister65
twister65
20 Sep 2018

Pull Request for Issue #22041 .

Summary of Changes

PlgCaptchaRecaptcha->onDisplay event returns HTML node instead of XML node.

Testing Instructions

I did my tests with recaptcha JComments (https://github.com/twister65/com_jcomments).
You can test it with any extension using reCaptcha plugin.

Expected result

recaptcha box should display.

Actual result

It appears.

Documentation Changes Required

Documentation was correct :
@return string The HTML to be embedded in the form.

avatar twister65 twister65 - open - 20 Sep 2018
avatar twister65 twister65 - change - 20 Sep 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Sep 2018
Category Front End Plugins
avatar twister65
twister65 - comment - 21 Sep 2018

I don't understand why the build failed ?

avatar wojsmol
wojsmol - comment - 21 Sep 2018

cc @SniperSister @zero-24 anther rips related failure.

avatar zero-24
zero-24 - comment - 21 Sep 2018

Fixed now had nothing todo with this PR.

avatar richard67
richard67 - comment - 22 Sep 2018

I have tested this item successfully on 32b013c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22270.

avatar richard67 richard67 - test_item - 22 Sep 2018 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 23 Sep 2018

I have tested this item successfully on 32b013c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22270.

avatar SharkyKZ SharkyKZ - test_item - 23 Sep 2018 - Tested successfully
avatar Quy Quy - change - 23 Sep 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 23 Sep 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22270.

avatar richard67
richard67 - comment - 25 Sep 2018

Why is this PR not being merged? It is RTC, it fixes a bug, it has no conflicts.

avatar mbabker
mbabker - comment - 25 Sep 2018

I'm not in here merging PRs every day (I usually try to clean out the RTC queue 2 or 3 times a week, just better for my sanity).

avatar richard67
richard67 - comment - 25 Sep 2018

Sure, I did not mean you personally. I hoped there are more than 1 maintainers merging PRs ;-)

avatar brianteeman
brianteeman - comment - 25 Sep 2018

Even if there are twenty people merging there wasn't exactly a desperate urgent need for you to start questioning

avatar richard67
richard67 - comment - 25 Sep 2018

Sorry when I disturbed too much. Just am worrying it will not go into RC.

avatar laoneo
laoneo - comment - 25 Sep 2018

@richard67 no need to say sorry. Our release process is not that clear for outsiders on a first glance. We handle it that way, that one person is the release lead and does the merging. For 3.9 it is @mbabker.

avatar richard67
richard67 - comment - 25 Sep 2018

I think I am not really an outsider, but thanks for the explanation.

avatar mbabker
mbabker - comment - 25 Sep 2018

And I've always said that outside of features going into .0 I don't care who merges what as long as it's properly tested and reviewed (and even though it doesn't look like it because I merge so many PRs so quickly, I actually do take the time to at least code review each PR even after everyone else tests things because I have caught a time or three things that should've never been marked RTC). Leave the release lead to make calls on features, but bug fixes don't need to sit around until I decide "hey, let's go merge some PRs".

avatar mbabker mbabker - change - 25 Sep 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-09-25 23:32:08
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 25 Sep 2018
avatar mbabker mbabker - merge - 25 Sep 2018

Add a Comment

Login with GitHub to post a comment