User tests: Successful: Unsuccessful:
Pull Request for Issue #22041 .
PlgCaptchaRecaptcha->onDisplay event returns HTML node instead of XML node.
I did my tests with recaptcha JComments (https://github.com/twister65/com_jcomments).
You can test it with any extension using reCaptcha plugin.
recaptcha box should display.
It appears.
Documentation was correct :
@return string The HTML to be embedded in the form.
Status | New | ⇒ | Pending |
Category | ⇒ | Front End Plugins |
cc @SniperSister @zero-24 anther rips related failure.
Fixed now had nothing todo with this PR.
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Why is this PR not being merged? It is RTC, it fixes a bug, it has no conflicts.
I'm not in here merging PRs every day (I usually try to clean out the RTC queue 2 or 3 times a week, just better for my sanity).
Sure, I did not mean you personally. I hoped there are more than 1 maintainers merging PRs ;-)
Even if there are twenty people merging there wasn't exactly a desperate urgent need for you to start questioning
Sorry when I disturbed too much. Just am worrying it will not go into RC.
@richard67 no need to say sorry. Our release process is not that clear for outsiders on a first glance. We handle it that way, that one person is the release lead and does the merging. For 3.9 it is @mbabker.
I think I am not really an outsider, but thanks for the explanation.
And I've always said that outside of features going into .0 I don't care who merges what as long as it's properly tested and reviewed (and even though it doesn't look like it because I merge so many PRs so quickly, I actually do take the time to at least code review each PR even after everyone else tests things because I have caught a time or three things that should've never been marked RTC). Leave the release lead to make calls on features, but bug fixes don't need to sit around until I decide "hey, let's go merge some PRs".
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-25 23:32:08 |
Closed_By | ⇒ | mbabker | |
Labels |
Added:
?
|
I don't understand why the build failed ?