[#22265] - Allow a database other than default to be specified
- Closed
- 26 Apr 2019
- Medium
- Build: staging
- # 22265
- Diff
- okonomiyaki3000:tagshelper-specifydb
- Success Hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr the build was successful Details
User tests: Successful: Unsuccessful:
Summary of Changes
Constructor takes an optional database object that will be used in all instance methods
Static functions can take an optional database object to use instead of default dbo
Also cleaned up some code in minor ways - much more can be done
Alternative database objects can now be used but default behavior will not have changed.
Testing Instructions
Since this class is used for working with tags, you should do some things that involve tags. Especially, add or remove tags from content items such as articles.
Expected result
There should be no change from the current behavior. That is, it should continue to work as usual.
Actual result
Yes.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
I don't think these travis errors are anything.
Is this a new Feature which should go in J4?
This should already be possible in j4, @okonomiyaki3000 please look at j4, if not possible please rebase this PR. Thx
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-26 12:46:47 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Removed:
J3 Issue
|
||
Actually, in
unTagItem, a table object is passed in. So why aren't we using the db object from the table object?