ooh getting excited - on my to do list for tomorrow

@brianteeman can you please tell when exactly you got that error? no such file or directory, open 'C:\htdocs\40\media\vendor\choices.min.js\css\choices.css
Maybe some screenshot.

I tried to build a couple times and cannot reproduce it currently.
I am not on Windows, maybe something platform specific.

It was part of the output of the npm i
I am on a train on a way to a sprint but as soon as I get there I will check this and provide more info

fs.js:145
    throw err;
    ^

Error: ENOENT: no such file or directory, open 'C:\htdocs\40\media\vendor\choices.min.js\css\choices.css'
    at Object.fs.openSync (fs.js:579:3)
    at Object.fs.writeFileSync (fs.js:1309:33)
    at files.forEach (C:\htdocs\40\build\build-modules-js\update.js:302:9)
    at Array.forEach (<anonymous>)
    at uglifyLegacyFiles (C:\htdocs\40\build\build-modules-js\update.js:294:9)
    at Object.copyAssets (C:\htdocs\40\build\build-modules-js\update.js:329:11)
    at Object.<anonymous> (C:\htdocs\40\build.js:65:22)
    at Module._compile (internal/modules/cjs/loader.js:702:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:713:10)
    at Module.load (internal/modules/cjs/loader.js:612:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:551:12)
    at Function.Module._load (internal/modules/cjs/loader.js:543:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:744:10)
    at startup (internal/bootstrap/node.js:238:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:572:3)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! joomla@4.0.0 install: `node build.js --copy-assets && node build.js --build-check`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the joomla@4.0.0 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:

@wilsonge I need to load the field from com_modules, in Module frontend editing form /components/com_config/forms/modules.xml I am doing with addfieldprefix:

<field
	name="position"
	type="ModulesPositionedit"
	label="COM_MODULES_FIELD_POSITION_LABEL"
	addfieldprefix="Joomla\Component\Modules\Administrator\Field"
/>

but nothing works, what is wrong?
Ignore, all is fine ?

@brianteeman please try one more run,
I think I found a reason, and made a fix, but cannot test my own

Sorry that change didnt work

Buiild with the latest change produced a css file with the content just the word "undefined" and a blank minified css file

okay, thanks,
and the error with not found ...media\vendor\choices.min.js\css\choices.css is gone or still there?

that error is gone

okay, then that error fixed ?

now, what is file path/name which contain "undefined"?

C:\htdocs\40\media\vendor\choices.js\css\choices.css

I think it ready to test, if there someone brave enough

Would be good if someone who have a Windows, to look at build failure, under Windows.
I cannot find why \media\vendor\choices.js\css\choices.css become empty after build.

OK So I just did a quick test here and things seems to work for module positions, tags and categories. There is a change here in that before we used to do ajax searching on tags after 3 characters were entered - now we are just loading all the tags in the system. But this is looking good. We obviously need to get windows sorted

There is a change here in that before we used to do ajax searching on tags after 3 characters were entered

it stays, it search with ajax (you can see ajax request in network tab)
the tags you see initially is actually loaded by Tags field (see getOptions()), it always was like that, and I always was wondered why we have it additionally to ajax ?

maybe we can disable AJAX for tag field then? or disable getOptions() for tag field?

@wilsonge I have update AJAX search, now the remote search enabled when
'tag_field_ajax_mode' == 1 (com_tags global Params) or field has attribute remote-search="true"

Can we get here some tests? Thanks

@laoneo it doesnt work in windows - waiting for @wilsonge to use my windows computer

Could you guys sort out the windows issue?

I am still here waiting for @wilsonge to use my computer

I'm off work today. Around till 5pm. Pinged you on twitter

Spent some time today with Brian. He should be submitting a PR later

For reference the problem is not with this PR but the build scripts on windows.

That will be a seperate PR I will submit tonight and doesnt really prevent this one fromm being merged

I am getting this error when opening an article with some fields

Warning: DOMDocument::loadHTML(): Tag joomla-field-fancy-select invalid in Entity, line: 2 in C:\htdocs\40\administrator\components\com_fields\Helper\FieldsHelper.php on line 315

see #22706 for the corrected(?) build script

I will check this weekend, also the conflicts

I "think" the error is related to the calendar field

I am getting this error when opening an article with some fields

@brianteeman please tell me which field types do you have in that article?

@laoneo do you remember what this thing is doing?

the warning because DOMDocument not know about a custom tags, hm

There were two fields. Calendar and text

@brianteeman should work now

@Fedik yes that problem has been resolved - thanks

So just to be clear is this PR now working (with a bit of a grim hack to the DomDocument stuff?)

for me, working :)

Thankyou for this!

As stated in #23289, choices.css is loaded after template.css, therefore overriding specific overrides in template.css