Feeling Lucky
?
[#22237] - Make sure manifest object returned before logging actions
- Fixed in Code Base
- 2 Oct 2018
- Medium
- Build: staging
- # 22237
- Diff
- joomdonation:patch-21
User tests: Successful: Unsuccessful:
Pull Request for Issue #22221.
Summary of Changes
This PR added some check to make sure $installer return a manifest object before logging install/uninstall/update action. Although it doesn't fix the root of the error, it is added to make sure install/uninstall/update process still working well as expected when action logs is enabled.
Testing Instructions
- Install latest staging (or 3.9 beta)
- Follow the instructions at #22221 , install/uninstall test library to confirm the issue
- Apply patch, confirm the fatal error does not happen again
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
joomdonation
- comment
- 26 Sep 2018
Could someone help testing this simple PR? The fatal error when uninstall library should be fixed for 3.9
Quy
- comment
- 26 Sep 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22237.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 26 Sep 2018
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22237.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-10-02 16:14:27 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on ad8d53c
Several libraries and packages with libraries successfully installed/uninstalled.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22237.