J3 Issue No Code Attached Yet
avatar PhilETaylor
PhilETaylor
17 Sep 2018

myJoomla.com users report that several files are "missing" from their webspace.

On investigation, for example,

administrator/templates/hathor/html/com_languages/installed/default_ftp.php

This file exists in staging here:

https://github.com/joomla/joomla-cms/blob/staging/administrator/templates/hathor/html/com_languages/installed/default_ftp.php

But is deleted here:

https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_admin/script.php#L533

It looks like something is out of sync here... maybe there are more files that can be removed from staging... The myJoomla.com file lists are compiled by the Stable Zip of the release.

The point is, why distribute the file, and then delete it?

Files effected:

/media/mod_languages/images/si_lk.gif
/media/jui/img/ajax-loader.gif
/libraries/fof/LICENSE.txt
/administrator/templates/hathor/html/com_languages/installed/default_ftp.php

ALSO Joomla is INCORRECTLY deleting /media/mod_languages/images/si_lk.gif This is because in the past someone added si_LK.gif and si_lk.gif (case sensitive) to the distribution, and now Joomla is deleting that in script.php - this is incorrect, because its deleting the lowercase (correct one) that Joomla needs even though in script.php its the si_LK.gif one - this is because someone who added that did not test PHP on all platforms... and did not understand that unlink is not case sensitive ;-)

avatar PhilETaylor PhilETaylor - open - 17 Sep 2018
avatar joomla-cms-bot joomla-cms-bot - change - 17 Sep 2018
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 17 Sep 2018
avatar PhilETaylor PhilETaylor - change - 17 Sep 2018
The description was changed
avatar PhilETaylor PhilETaylor - edited - 17 Sep 2018
avatar PhilETaylor PhilETaylor - change - 17 Sep 2018
The description was changed
avatar PhilETaylor PhilETaylor - edited - 17 Sep 2018
avatar PhilETaylor PhilETaylor - change - 17 Sep 2018
The description was changed
avatar PhilETaylor PhilETaylor - edited - 17 Sep 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 17 Sep 2018
Status New Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 17 Sep 2018
Category com_joomlaupdate
avatar brianteeman brianteeman - change - 17 Sep 2018
Labels Added: J3 Issue
avatar brianteeman brianteeman - labeled - 17 Sep 2018
avatar Scrabble96
Scrabble96 - comment - 23 Sep 2018

It seems that the language/index.html file has been changed, too, from <!DOCTYPE html><title></title> to <html><head><title></title></head><body></body></html> .

avatar brianteeman brianteeman - change - 26 Sep 2018
Labels Added: ?
avatar brianteeman brianteeman - labeled - 26 Sep 2018
avatar onderzoekspraktijk
onderzoekspraktijk - comment - 10 Oct 2018

For sometime now this issue persists.
Today updated to joomla 3.8.13, checked afterwards using Watchfulli audit, wich reports as missing:
/libraries/fof/LICENSE.txt
/media/jui/img/ajax-loader.gif
/media/mod_languages/images/si_lk.gif.
The first one will be Akeeba, the last two are Joomla core files.

So I used the re-install Joomla core filed button inside the Joomla Update component. Cjecked again with Watchfulli audit and got the exact same error message again.

I suppose this is no show stopper, but it feels not right.

avatar Scrabble96
Scrabble96 - comment - 11 Oct 2018

I suppose this is no show stopper, but it feels not right.

I use Watchful.li, too, which is how I first came across the issue. Would you be able to post your comment above on the Joomla 3.8.13 discussion forum? I made a comment about it but I think I'm either being ignored or they think I'm not a Super User, which I am. If you comment about the same missing files, they might take more notice.

avatar infograf768
infograf768 - comment - 11 Oct 2018

I have proposed maintainers to delete these lines in script.php

avatar PhilETaylor
PhilETaylor - comment - 11 Oct 2018

I have proposed miantainers to delete these lines in script.php

Which is the wrong solution!

The correct solution for three of the files is not to distribute them

The correct solution for si_lk.gif is to ONLY delete si_LK.gif and not si_lk.gif

avatar PhilETaylor
PhilETaylor - comment - 11 Oct 2018

ok I have opened #22580, #22581, #22582, #22583 to address some of these.

I don't have time to unpick the CaseSensitive si_lk.gif deletion at the moment, I'll come back to that as it needs to be tested on multiple file systems and platforms as we only need to delete the si_LK.gif and not the si_lk.gif

avatar onderzoekspraktijk
onderzoekspraktijk - comment - 11 Oct 2018

Okay!

avatar Scrabble96
Scrabble96 - comment - 11 Oct 2018

ok I have opened #22580, #22581, #22582, #22583 to address some of these.

I don't have time to unpick the CaseSensitive si_lk.gif deletion at the moment, I'll come back to that as it needs to be tested on multiple file systems and platforms as we only need to delete the si_LK.gif and not the si_lk.gif

Thank you.

avatar PhilETaylor
PhilETaylor - comment - 15 Oct 2018

after #22648 and #22646 the only thing left is the si_lk.gif and I dont know how best to handle that as PHP appears to not respect case sensitivity.

avatar brianteeman brianteeman - change - 15 Oct 2018
Labels Removed: ?
avatar brianteeman brianteeman - unlabeled - 15 Oct 2018
avatar brianteeman
brianteeman - comment - 15 Oct 2018
avatar PhilETaylor PhilETaylor - change - 15 Oct 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-10-15 18:38:17
Closed_By PhilETaylor
avatar PhilETaylor PhilETaylor - close - 15 Oct 2018

Add a Comment

Login with GitHub to post a comment