[#2221] - # [fix] session never expires after applying #2218
- Closed
- 11 Oct 2013
- Medium
- Build: master
- # 2221
- Diff
- phproberto:session-expire
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
I can only confirm that session wasn't expiring and after applying this it does. This was tested by David, JM & me.
I stand by my gut feeling on this one. Something really doesn't feel right about it.
In my tests it worked exactly how the session expiry worked before the changes. The session does expire but you do get to see the last page you were on via direct link and only know the session has expired when you click somewhere
I have same "gut feeling" as @mbabker .
Could this deep rooted issue be related with the bug in 3.1.5 that when a session expired (in admin area at least) that it needed a second click to really expire (aka you could access 1 more page before the session really expired) ?
garyamort
-
You should have never needed this line. When JFactory creates the session it is adding that expire option to the array. My gut tells me this PR is masking another deeply rooted issue if you need these lines in this file to have your session expire when Elin and I didn't when testing originally last night.