Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#22207] - [4.0] Fix Slider Toolbar Button

? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
16 Sep 2018

Summary of Changes

Currently the slider button throws a PHP notice

PHP Warning:  Declaration of Joomla\CMS\Toolbar\Button\SliderButton::fetchId($type, $name) should be compatible with Joomla\CMS\Toolbar\ToolbarButton::fetchId() in /Users/george/Sites/joomla-cms/libraries/src/Toolbar/Button/SliderButton.php on line 113

(found when running the stub generator as i don't see any uses of this in core). I think it wasn't properly migrated when doing #19670

This should fix all the issues (however I can't be sure because there aren't any uses of this in core)

avatar wilsonge wilsonge - open - 16 Sep 2018
avatar wilsonge wilsonge - change - 16 Sep 2018
Status New ⇒ Pending
avatar wilsonge wilsonge - change - 16 Sep 2018
Title
…
[4.0] Fix Slider Button
[4.0] Fix Slider Toolbar Button
avatar wilsonge wilsonge - edited - 16 Sep 2018
avatar joomla-cms-bot joomla-cms-bot - change - 16 Sep 2018
Category ⇒ Libraries
avatar wilsonge wilsonge - change - 16 Sep 2018
Labels Added: ?
avatar laoneo laoneo - change - 28 Sep 2018
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-09-28 06:50:56
Closed_By ⇒ laoneo
avatar laoneo laoneo - close - 28 Sep 2018
avatar laoneo laoneo - merge - 28 Sep 2018
avatar laoneo
laoneo - comment - 28 Sep 2018

Thanks

Add a Comment

Login with GitHub to post a comment