User tests: Successful: Unsuccessful:
Pull Request for new issue.
title_holder
to columns list in insert statement for table #__action_log_config
in schema update 3.9.0-2018-05-05.sql
for PostgreSQL to fix SQL error about missing column title_holder
on Joomla update.3.9.0-2018-06-02.sql
for PostgreSQL to fix SQL error about missing column Article
on Joomla update.3.9.0-2018-07-09.sql
for PostgreSQL to fix SQL error near "´".Without this PR, update from 3.8.12 to 3.9-beta2-dev nightly build from today fails on PostgreSQL with SQL errors.
With this PR, update from 3.8.12 to 3.9-beta2-dev nightly build from today plus this PR applied finish with success.
Code review:
3.9.0-2018-07-09.sql
for PostgreSQL is correct.Real test:
Code review:
postgresql/3.9.0-2018-05-05.sql
have same columns in their column list because they both insert data for the same columns.WHERE "type_title" = 'Article'
is quoted correctly in schema update postgresql/3.9.0-2018-06-02.sql
.postgresql/3.9.0-2018-07-09.sql
.Real test:
Update finish with success.
Code review:
postgresql/3.9.0-2018-05-05.sql
for PostgreSQL the column title_holder
is missing in the columns list of the insert statement for table #__action_log_config
. This causes an SQL error when updating a 3.8.12 to the night build of 3.9-beta2-dev from today.WHERE "type_title" = "Article"
is not quoted correctly in schema update postgresql/3.9.0-2018-06-02.sql
.postgresql/3.9.0-2018-07-09.sql
.Real test:
Update breaks with SQL errors.
None.
Status | New | ⇒ | Pending |
Category | ⇒ | Postgresql SQL Administration com_admin |
Title |
|
Labels |
Added:
?
|
Title |
|
Title |
|
Title |
|
Now it is ready for being tested.
Drone failure seems not to be related to the changes in this PR.
Drone failure seems not to be related to the changes in this PR.
I have tested this item
review
Title |
|
Title |
|
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-16 11:03:12 |
Closed_By | ⇒ | wilsonge |
Thanks!
Welcome :-)
@alikon @SharkyKZ Can you check this PR here, too?