? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
15 Sep 2018

Pull Request for new issue.

Summary of Changes

  1. Add missing column title_holder to columns list in insert statement for table #__action_log_config in schema update 3.9.0-2018-05-05.sql for PostgreSQL to fix SQL error about missing column title_holder on Joomla update.
  2. Correct text quoting in schema update 3.9.0-2018-06-02.sql for PostgreSQL to fix SQL error about missing column Article on Joomla update.
  3. Correct names quoting in schema update 3.9.0-2018-07-09.sql for PostgreSQL to fix SQL error near "´".

Without this PR, update from 3.8.12 to 3.9-beta2-dev nightly build from today fails on PostgreSQL with SQL errors.

With this PR, update from 3.8.12 to 3.9-beta2-dev nightly build from today plus this PR applied finish with success.

Testing Instructions

Code review:

  • Issues 1. and 2.: Verify the SQL statements corrected by this PR are consistent with the corresponding statements in the same schema updates for MySQL.
  • Issue3.: Check that correction in schema update 3.9.0-2018-07-09.sql for PostgreSQL is correct.

Real test:

  1. Update a 3.8.12 to the latest 3.9-beta2-dev nightly build from today. Result: See actual result below.
  2. Download the update package of the latest 3.9-beta2-dev nightly build from today, unpack it, apply the changes from this PR here, pack it again and update a 3.8.12 to that modified package using the package upload method. Result: See expected result below.

Expected result

Code review:

  1. Both statements in schema update postgresql/3.9.0-2018-05-05.sql have same columns in their column list because they both insert data for the same columns.
  2. WHERE "type_title" = 'Article' is quoted correctly in schema update postgresql/3.9.0-2018-06-02.sql.
  3. Names are correctly quoted in schema update postgresql/3.9.0-2018-07-09.sql.

Real test:
Update finish with success.

Actual result

Code review:

  1. In the schema update postgresql/3.9.0-2018-05-05.sql for PostgreSQL the column title_holder is missing in the columns list of the insert statement for table #__action_log_config. This causes an SQL error when updating a 3.8.12 to the night build of 3.9-beta2-dev from today.
  2. WHERE "type_title" = "Article" is not quoted correctly in schema update postgresql/3.9.0-2018-06-02.sql.
  3. Names are quoted in the MySQL way in schema update postgresql/3.9.0-2018-07-09.sql.

Real test:
Update breaks with SQL errors.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 15 Sep 2018
avatar richard67 richard67 - change - 15 Sep 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Sep 2018
Category Postgresql SQL Administration com_admin
avatar richard67
richard67 - comment - 15 Sep 2018

@alikon @SharkyKZ Can you check this PR here, too?

avatar richard67 richard67 - change - 15 Sep 2018
Title
Fix SQL syntax error missing column in schema update form PostgreSQL
Fix SQL error missing column in schema update form PostgreSQL
avatar richard67 richard67 - edited - 15 Sep 2018
avatar richard67 richard67 - change - 15 Sep 2018
Labels Added: ?
avatar richard67 richard67 - change - 15 Sep 2018
Title
Fix SQL error missing column in schema update form PostgreSQL
Fix SQL errors "missing column" in schema update form PostgreSQL
avatar richard67 richard67 - edited - 15 Sep 2018
avatar richard67 richard67 - change - 15 Sep 2018
Title
Fix SQL errors "missing column" in schema update form PostgreSQL
Fix SQL errors "missing column" in schema updates for PostgreSQL
avatar richard67 richard67 - edited - 15 Sep 2018
avatar richard67 richard67 - change - 15 Sep 2018
The description was changed
avatar richard67 richard67 - edited - 15 Sep 2018
avatar richard67 richard67 - change - 15 Sep 2018
The description was changed
Title
Fix SQL errors "missing column" in schema updates for PostgreSQL
Fix SQL errors in schema updates for PostgreSQL
avatar richard67 richard67 - edited - 15 Sep 2018
avatar richard67 richard67 - edited - 15 Sep 2018
avatar richard67 richard67 - change - 15 Sep 2018
The description was changed
avatar richard67 richard67 - edited - 15 Sep 2018
avatar richard67
richard67 - comment - 15 Sep 2018

Now it is ready for being tested.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22201.

avatar richard67
richard67 - comment - 15 Sep 2018

Drone failure seems not to be related to the changes in this PR.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22201.

avatar richard67
richard67 - comment - 15 Sep 2018

Drone failure seems not to be related to the changes in this PR.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22201.

avatar alikon
alikon - comment - 16 Sep 2018

I have tested this item successfully on 08a9f97

review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22201.

avatar alikon alikon - test_item - 16 Sep 2018 - Tested successfully
avatar richard67 richard67 - change - 16 Sep 2018
Title
Fix SQL errors in schema updates for PostgreSQL
[postgresql] Fix SQL errors in schema updates which make update fail
avatar richard67 richard67 - edited - 16 Sep 2018
avatar richard67 richard67 - edited - 16 Sep 2018
avatar richard67 richard67 - change - 16 Sep 2018
Title
[postgresql] Fix SQL errors in schema updates which make update fail
[postgresql] Fix SQL errors in schema updates which make update from 3.8.12 to staging fail
avatar wilsonge wilsonge - change - 16 Sep 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-09-16 11:03:12
Closed_By wilsonge
avatar wilsonge wilsonge - close - 16 Sep 2018
avatar wilsonge wilsonge - merge - 16 Sep 2018
avatar wilsonge
wilsonge - comment - 16 Sep 2018

Thanks!

avatar richard67
richard67 - comment - 16 Sep 2018

Welcome :-)

Add a Comment

Login with GitHub to post a comment