Add missing column title_holder to columns list in insert statement for table #__action_log_config in schema update 3.9.0-2018-05-05.sql for PostgreSQL to fix SQL error about missing column title_holder on Joomla update.
Correct text quoting in schema update 3.9.0-2018-06-02.sql for PostgreSQL to fix SQL error about missing column Article on Joomla update.
Correct names quoting in schema update 3.9.0-2018-07-09.sql for PostgreSQL to fix SQL error near "´".
Without this PR, update from 3.8.12 to 3.9-beta2-dev nightly build from today fails on PostgreSQL with SQL errors.
With this PR, update from 3.8.12 to 3.9-beta2-dev nightly build from today plus this PR applied finish with success.
Testing Instructions
Code review:
Issues 1. and 2.: Verify the SQL statements corrected by this PR are consistent with the corresponding statements in the same schema updates for MySQL.
Issue3.: Check that correction in schema update 3.9.0-2018-07-09.sql for PostgreSQL is correct.
Real test:
Update a 3.8.12 to the latest 3.9-beta2-dev nightly build from today. Result: See actual result below.
Download the update package of the latest 3.9-beta2-dev nightly build from today, unpack it, apply the changes from this PR here, pack it again and update a 3.8.12 to that modified package using the package upload method. Result: See expected result below.
Expected result
Code review:
Both statements in schema update postgresql/3.9.0-2018-05-05.sql have same columns in their column list because they both insert data for the same columns.
WHERE "type_title" = 'Article' is quoted correctly in schema update postgresql/3.9.0-2018-06-02.sql.
Names are correctly quoted in schema update postgresql/3.9.0-2018-07-09.sql.
Real test:
Update finish with success.
Actual result
Code review:
In the schema update postgresql/3.9.0-2018-05-05.sql for PostgreSQL the column title_holder is missing in the columns list of the insert statement for table #__action_log_config. This causes an SQL error when updating a 3.8.12 to the night build of 3.9-beta2-dev from today.
WHERE "type_title" = "Article" is not quoted correctly in schema update postgresql/3.9.0-2018-06-02.sql.
Names are quoted in the MySQL way in schema update postgresql/3.9.0-2018-07-09.sql.
@alikon @SharkyKZ Can you check this PR here, too?