User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_users |
Title |
|
I wouldn't use the eye as we use that for revealing a password - I actually thought the icon you chose was perfect. I can't think of another really suitable one.
I really like this PR
Thank you. So I let this icon. It is also a a11y improvement for people with motoric disabilities.
Off topic. In the UK the word spastic although technically correct has become a very offensive word and we don't use it.
Thank you @brianteeman. How embarassing. It was not my intention
i was sure it wasn't
I have tested this item
Have tested patch successfully. OT: As my patchtester doesn't work at the moment, I changed the file: administrator/components/com_users/tmpl/groups/default.php accordingly.
What do you think about removing the word "advanced" from the heading. Its a pretty long heading in english and possibly even longer in other languages
OT: As my patchtester doesn't work at the moment, I changed the file: administrator/components/com_users/tmpl/groups/default.php accordingly.
I'd like to remove the "advanecd". It has not information, because no "not advanced" report exists.
Can you do it?
just add the change to this pr
Labels |
Added:
?
|
Category | Administration com_users | ⇒ | Administration com_users Language & Strings |
The "Advanced" is still in some Texts. Not sure what it exactly means, so I did not change it for other language keys.
Will you be making a similar change to the users view?
The change itself is easy and I will do it. Let's see ifthere is sufficient place in the table head
we might be able to just use "permissions" in the head
Labels |
Added:
?
|
I've lost my struggle with github, wanted to make a new PR but now it is here
And what to do you think about removing the ability to conditionally display this column. I only did it that way in j3 to avoid any discussion about it being a b/c change. Personally I would remove the condition but I'm ok if you want to keep it
I agree to remove it. Who can see users and usergroups can also see the permissions. I did not know the reason for the condition. When I leaned 1.6.. 2.5, the permissions were only visible in debug mode, maybe for performance?
Iirc they were an afterthought. Let's remove them for J4 and move forward. Thanks for doing this.
There are params in the "Advanced Tab". Kind of "hidden secrets" :)
Yes. it was me that put them there. They can go now as well.
Title |
|
Now that we have changed the title to just "Permissions" can you update the following as well please for consistency
COM_USERS_VIEW_DEBUG_GROUP_TITLE="Advanced Permissions Report for Group #%d, %s"
COM_USERS_VIEW_DEBUG_USER_TITLE="Advanced Permissions Report for User #%d, %s"
Then it's all good to go for me.
I have tested this item
I have tested this item
@brianteeman even if
I'll do it ;) because every times when I'm in the userr administration I click the wrong link
@brianteeman @alikon what do you think? for staging or for 3.9?
staging
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-17 05:55:46 |
Closed_By | ⇒ | laoneo | |
Labels |
Added:
?
|
Thanks
While this is a million times better than before, Im not convinced its the right place for it.
I think the notes and the APR should be tabs in the Edit User view instead as thats the more logical place for them
The Add Notes is an action, so could also have been in the actions menu button. (which I dont see in these screenshots, darn admin template strikes again)
I think it is a great idea to have the permissions also in a tab in the edit screen.
But when I am working with ACL, I use to check the permissions of users one by one in the list view and compare if it is right. It would cost me more time to go to the edit screen for every user. So I think it is all right to have the links on the list view.
moving add a note to the toolbar is a good idea
I would like to have another icon for "get a permission report" - but not sure what could be a good visualisation. Maybe the eye?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22190.