? ? ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
15 Sep 2018

Summary of Changes

In user groups list view: Bring the "advanced permission" link to an own column.

usergroups

users

Documentation Changes Required

yes

avatar chmst chmst - open - 15 Sep 2018
avatar chmst chmst - change - 15 Sep 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Sep 2018
Category Administration com_users
avatar chmst chmst - change - 15 Sep 2018
Title
Separate columns for group and permissions button
[4.0] User groups: Separate columns for group and permissions button
avatar chmst chmst - edited - 15 Sep 2018
avatar chmst
chmst - comment - 15 Sep 2018

I would like to have another icon for "get a permission report" - but not sure what could be a good visualisation. Maybe the eye?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22190.

avatar brianteeman
brianteeman - comment - 15 Sep 2018

I wouldn't use the eye as we use that for revealing a password - I actually thought the icon you chose was perfect. I can't think of another really suitable one.

I really like this PR

avatar chmst
chmst - comment - 15 Sep 2018

Thank you. So I let this icon. It is also a a11y improvement for people with motoric disabilities.

avatar brianteeman
brianteeman - comment - 15 Sep 2018

Off topic. In the UK the word spastic although technically correct has become a very offensive word and we don't use it.

avatar chmst
chmst - comment - 15 Sep 2018

Thank you @brianteeman. How embarassing. It was not my intention

avatar brianteeman
brianteeman - comment - 15 Sep 2018

i was sure it wasn't

avatar ChristineWk
ChristineWk - comment - 15 Sep 2018

I have tested this item successfully on 60914a4

Have tested patch successfully. OT: As my patchtester doesn't work at the moment, I changed the file: administrator/components/com_users/tmpl/groups/default.php accordingly.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22190.

avatar ChristineWk ChristineWk - test_item - 15 Sep 2018 - Tested successfully
avatar brianteeman
brianteeman - comment - 15 Sep 2018

What do you think about removing the word "advanced" from the heading. Its a pretty long heading in english and possibly even longer in other languages

avatar ChristineWk
ChristineWk - comment - 15 Sep 2018

OT: As my patchtester doesn't work at the moment, I changed the file: administrator/components/com_users/tmpl/groups/default.php accordingly.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22190.

avatar chmst
chmst - comment - 15 Sep 2018

I'd like to remove the "advanecd". It has not information, because no "not advanced" report exists.
Can you do it?

avatar brianteeman
brianteeman - comment - 15 Sep 2018

just add the change to this pr

avatar chmst chmst - change - 15 Sep 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 15 Sep 2018
Category Administration com_users Administration com_users Language & Strings
avatar chmst
chmst - comment - 15 Sep 2018

The "Advanced" is still in some Texts. Not sure what it exactly means, so I did not change it for other language keys.

avatar brianteeman
brianteeman - comment - 15 Sep 2018

Will you be making a similar change to the users view?

avatar chmst
chmst - comment - 15 Sep 2018

The change itself is easy and I will do it. Let's see ifthere is sufficient place in the table head

avatar brianteeman
brianteeman - comment - 15 Sep 2018

we might be able to just use "permissions" in the head

avatar chmst chmst - change - 15 Sep 2018
Labels Added: ?
avatar chmst
chmst - comment - 15 Sep 2018

I've lost my struggle with github, wanted to make a new PR but now it is here

avatar brianteeman
brianteeman - comment - 15 Sep 2018

And what to do you think about removing the ability to conditionally display this column. I only did it that way in j3 to avoid any discussion about it being a b/c change. Personally I would remove the condition but I'm ok if you want to keep it

avatar chmst
chmst - comment - 15 Sep 2018

I agree to remove it. Who can see users and usergroups can also see the permissions. I did not know the reason for the condition. When I leaned 1.6.. 2.5, the permissions were only visible in debug mode, maybe for performance?

avatar brianteeman
brianteeman - comment - 15 Sep 2018

Iirc they were an afterthought. Let's remove them for J4 and move forward. Thanks for doing this.

avatar chmst
chmst - comment - 15 Sep 2018

There are params in the "Advanced Tab". Kind of "hidden secrets" :)

avatar brianteeman
brianteeman - comment - 15 Sep 2018

Yes. it was me that put them there. They can go now as well.

avatar chmst chmst - change - 15 Sep 2018
Title
[4.0] User groups: Separate columns for group and permissions button
[4.0] Users and User groups: Separate columns for group and permissions button
avatar chmst chmst - edited - 15 Sep 2018
avatar chmst chmst - change - 15 Sep 2018
The description was changed
avatar chmst chmst - edited - 15 Sep 2018
avatar brianteeman
brianteeman - comment - 15 Sep 2018

Now that we have changed the title to just "Permissions" can you update the following as well please for consistency

COM_USERS_VIEW_DEBUG_GROUP_TITLE="Advanced Permissions Report for Group #%d, %s"
COM_USERS_VIEW_DEBUG_USER_TITLE="Advanced Permissions Report for User #%d, %s"

Then it's all good to go for me.

avatar brianteeman
brianteeman - comment - 16 Sep 2018

I have tested this item successfully on 4cbbe99


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22190.

avatar brianteeman brianteeman - test_item - 16 Sep 2018 - Tested successfully
avatar brianteeman
brianteeman - comment - 16 Sep 2018

thanks @chmst great improvement

avatar alikon
alikon - comment - 16 Sep 2018

yes indeed
can be backported on 3.X too ? @chmst

avatar brianteeman
brianteeman - comment - 16 Sep 2018

@alikon if backported it would need to keep the conditional display of the column

avatar alikon
alikon - comment - 16 Sep 2018

I have tested this item successfully on 4cbbe99


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22190.

avatar alikon alikon - test_item - 16 Sep 2018 - Tested successfully
avatar alikon
alikon - comment - 16 Sep 2018

@brianteeman even if

avatar chmst
chmst - comment - 16 Sep 2018

I'll do it ;) because every times when I'm in the userr administration I click the wrong link

avatar chmst
chmst - comment - 16 Sep 2018

@brianteeman @alikon what do you think? for staging or for 3.9?

avatar brianteeman
brianteeman - comment - 16 Sep 2018

staging

avatar Quy Quy - change - 16 Sep 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 16 Sep 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22190.

avatar laoneo laoneo - change - 17 Sep 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-09-17 05:55:46
Closed_By laoneo
Labels Added: ?
avatar laoneo laoneo - close - 17 Sep 2018
avatar laoneo laoneo - merge - 17 Sep 2018
avatar laoneo
laoneo - comment - 17 Sep 2018

Thanks

avatar PhilETaylor
PhilETaylor - comment - 17 Sep 2018

While this is a million times better than before, Im not convinced its the right place for it.

I think the notes and the APR should be tabs in the Edit User view instead as thats the more logical place for them

The Add Notes is an action, so could also have been in the actions menu button. (which I dont see in these screenshots, darn admin template strikes again)

avatar chmst
chmst - comment - 17 Sep 2018

I think it is a great idea to have the permissions also in a tab in the edit screen.

But when I am working with ACL, I use to check the permissions of users one by one in the list view and compare if it is right. It would cost me more time to go to the edit screen for every user. So I think it is all right to have the links on the list view.

avatar brianteeman
brianteeman - comment - 17 Sep 2018

moving add a note to the toolbar is a good idea

Add a Comment

Login with GitHub to post a comment