? ?
avatar continga
continga
14 Sep 2018

When adding nested subforms in Joomla 4.0.0-alpha3 and adding multiple rows of the most-inner subform, the add/remove buttons of the more outer subforms are not clickable anymore.

Steps to reproduce the issue

  1. Install Joomla 4.0.0-alpha3
  2. Edit the file plugins/fields/checkboxes/params/checkboxes.xml and add the following after line 26:
<field
        name="subformlevel2"
        type="subform"
        label="PLG_FIELDS_CHECKBOXES_PARAMS_OPTIONS_LABEL"
        layout="joomla.form.field.subform.repeatable-table"
        icon="list"
        multiple="true"
>
        <form hidden="true" name="list_templates_modal" repeat="true">
                <field
                        name="name_lvl2"
                        type="text"
                        label="PLG_FIELDS_CHECKBOXES_PARAMS_OPTIONS_NAME_LABEL"
                        size="30"
                />
                <field
                        name="subformlevel3"
                        type="subform"
                        label="PLG_FIELDS_CHECKBOXES_PARAMS_OPTIONS_LABEL"
                        layout="joomla.form.field.subform.repeatable-table"
                        icon="list"
                        multiple="true"
                >
                        <form hidden="true" name="list_templates_modal" repeat="true">
                                <field
                                        name="name_lvl3"
                                        type="text"
                                        label="PLG_FIELDS_CHECKBOXES_PARAMS_OPTIONS_NAME_LABEL"
                                        size="30"
                                />
                        </form>
                </field>
        </form>
</field>
  1. In the Joomla installation, go to the Backend, Content -> Fields -> New, change the Type to Checkboxes
  2. Add a new row of the Checkbox values, and a new row of the then appearing inner subform, and a new row of the then appearing inner subform, so you have 3 rows of the 3 nested subforms - like in this screenshot:
    image
  3. Try to click on the add or remove buttons of the outer subforms (not the innermost) - they are not working, there isn't even an onclick-event assigned to them.

Expected result

The outermost add/remove buttons should work, they should add a new row of their respective subform.

Actual result

The buttons do nothing, there isn't even an onlick event assigned to them.

System information (as much as possible)

Tested on Joomla 4.0.0-alpha3 using Firefox 62.0 on Linux.

Additional comments

I noticed this problem when testing this functionality in Joomla 4 regarding PR #17552 (re @Fedik )

avatar continga continga - open - 14 Sep 2018
avatar joomla-cms-bot joomla-cms-bot - change - 14 Sep 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 14 Sep 2018
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 14 Sep 2018

can you please test on Nightly Build?

avatar franz-wohlkoenig franz-wohlkoenig - change - 14 Sep 2018
Status New Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 14 Sep 2018
Category Plugins
avatar continga continga - change - 14 Sep 2018
The description was changed
avatar continga continga - edited - 14 Sep 2018
avatar continga
continga - comment - 14 Sep 2018

Well, with the latest Nightly Build, the system seems completely broken tbh.

When clicking Content -> Fields -> New, only the name of the field can be set, not the Type etc:
image

After saving it, I get access to the other options, so I testwise added the 3 nested subforms for the Textfield type:
image

But now nothing happens at all when clicking on the "Add" button, so the whole Subform system is broken in the latest nightly build.

avatar Fedik
Fedik - comment - 14 Sep 2018

I just checked and can confirm, the subform field is broken
I will check more, when will have some time

something with build scrip

avatar brianteeman brianteeman - change - 14 Sep 2018
Labels Added: ?
avatar brianteeman brianteeman - labeled - 14 Sep 2018
avatar Fedik
Fedik - comment - 14 Sep 2018

please test #22185

avatar franz-wohlkoenig franz-wohlkoenig - change - 14 Sep 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-09-14 16:26:22
Closed_By franz-wohlkoenig
avatar joomla-cms-bot joomla-cms-bot - change - 14 Sep 2018
Closed_By franz-wohlkoenig joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 14 Sep 2018
avatar joomla-cms-bot
joomla-cms-bot - comment - 14 Sep 2018
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 14 Sep 2018

closed as having Pull Request #22185

avatar continga
continga - comment - 14 Sep 2018

@franz-wohlkoenig Can we please reopen this issue?

The problem with the nightly build (subforms not working at all) is fixed with #22185 but the main problem from the opening post is still present.

I just tested the main problem (described in the opening post) on 4.0-dev at version e051bb2 with the patch applied from #22185 but still the add / remove buttons are not clickable:
image

avatar joomla-cms-bot joomla-cms-bot - change - 14 Sep 2018
Status Closed New
Closed_Date 2018-09-14 16:26:22
Closed_By joomla-cms-bot
avatar franz-wohlkoenig franz-wohlkoenig - change - 14 Sep 2018
Closed_Date 0000-00-00 00:00:00
avatar joomla-cms-bot joomla-cms-bot - reopen - 14 Sep 2018
avatar joomla-cms-bot
joomla-cms-bot - comment - 14 Sep 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 14 Sep 2018
Status New Discussion
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 14 Sep 2018

Reopened as stated above.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22183.

avatar Fedik
Fedik - comment - 14 Sep 2018

but still the add / remove buttons are not clickable

this is a styling issue,
so no issue here ?

screen 2018-09-14 21 23 34 585x518

btw, I would not recommend to use very deeeeeep nested subform

avatar brianteeman brianteeman - change - 15 Sep 2018
Labels Added: J4 Issue
avatar brianteeman brianteeman - labeled - 15 Sep 2018
avatar continga
continga - comment - 16 Sep 2018

well, you are right @Fedik ... I removed that element from the page for taking the above screenshot, but did then not check whether that element was causing the error xD sorry...

Should be then close this issue, or should we keep it open to fix the problem with the overlaying element?

avatar Fedik
Fedik - comment - 16 Sep 2018

I guess can close it, because the issue was caused not by real use case but by the testing instruction.

avatar franz-wohlkoenig franz-wohlkoenig - change - 16 Sep 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-09-16 17:13:14
Closed_By franz-wohlkoenig
avatar joomla-cms-bot joomla-cms-bot - change - 16 Sep 2018
Closed_By franz-wohlkoenig joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 16 Sep 2018
avatar joomla-cms-bot
joomla-cms-bot - comment - 16 Sep 2018
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 16 Sep 2018

Closed as stated above.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22183.

avatar franz-wohlkoenig franz-wohlkoenig - unlabeled - 20 Apr 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 20 Apr 2019
Labels Removed: J4 Issue

Add a Comment

Login with GitHub to post a comment