? Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
14 Sep 2018

Pull Request for Issue #21973 .

Summary of Changes

Resets the workflow, when the category is changed and a new workflow applied

Testing Instructions

  • Create 2 workflows and assign them to 2 different categories

  • Create an article for category 1

  • Execute transitions

  • Change the category

  • Do the same with the batch => move

Expected result

if category is changed and they have different workflows the new workflow is assigned

avatar bembelimen bembelimen - open - 14 Sep 2018
avatar bembelimen bembelimen - change - 14 Sep 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Sep 2018
Category Administration com_content Libraries
avatar brianteeman
brianteeman - comment - 14 Sep 2018

I was concerned that when you changed the category what would happen to the stage/transition/condition of the item if the new workflow had different stage/transition/condition.

I didn't get as far as testing that because if you change the category then the stage/transition/condition changes to the default one.

To test this yourself create two identical workflow and assign each to a category

Create an article in category 1 and change the state to unpublished
Then change the category of the article to category 2 and it will be automatically published (the default of the new workflow)

I know that this PR says it "resets" the workflow so in that case it could be said to be correct as it does what you say but without any notification in joomla itself it is definitely never going to be expected that changing the category of an article could publish it.

Sorry but I don't have any suggestion as I cannot see a way around this other than only having one workflow enabled per site


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22180.
avatar brianteeman
brianteeman - comment - 14 Sep 2018

I have tested this item ? unsuccessfully on 3b50277


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22180.

avatar brianteeman brianteeman - test_item - 14 Sep 2018 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 22 Sep 2018

I am at a drupal sprint and just checked how their workflow stuff works specifically the multiple workflows.

Drupal does allow multiple workflows on the site but you can only have one workflow for each content-type. There is no way to change a workflow based on taxonomy which in our terms means one workflow per component. /cc @wilsonge

avatar wilsonge
wilsonge - comment - 24 Sep 2018

So you're suggesting that we shouldn't allow changing of workflows in a given category?

avatar brianteeman
brianteeman - comment - 24 Sep 2018

I am saying more than that - there should only be one workflow per component

avatar bembelimen
bembelimen - comment - 24 Sep 2018

I still think, that changing a category should not change the workflow, but I also think, that Joomla! shouldn't limit itself in terms of the number of workflows, just because Drupal does it... because Joomla! can handle unlimited workflows per component...

avatar brianteeman
brianteeman - comment - 24 Sep 2018

My point as shown by examples above is that we are not able to have multiple workflows per component that actually work

avatar csthomas
csthomas - comment - 24 Sep 2018

I still think, that changing a category should not change the workflow...

Me too. The approver may want to move the article to a more appropriate category or subcategory not visible by author.

avatar brianteeman
brianteeman - comment - 24 Sep 2018

Thats the entire point. If you move content then you expect it to work the same as everything else in the category. Remember that you could have a stage called X than has condition Y in category 1 but a stage called X with a condition Z in the new category. How can you tell the difference

avatar bembelimen bembelimen - change - 27 Oct 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-10-27 08:05:57
Closed_By bembelimen
Labels Added: ?
avatar bembelimen bembelimen - close - 27 Oct 2018

Add a Comment

Login with GitHub to post a comment