[#22175] - [staging][fix] An admin menu item can't be associated
- Closed
- 16 Sep 2018
- Medium
- Build: staging
- # 22175
- infograf768:allmenus
Summary of Changes
Display the Associations toolbar only for site menu items
Testing Instructions
Create a custom admin menu
Create an admin menu item in this menu.
The toolbar "Associations" displays.
It should not.
This was forgotten in my PR #21022
Before patch
After patch
can be merged on review as it is quite obvious.
| Status | New | ⇒ | Discussion |
| Category | ⇒ | Administration com_associations com_menus |
Issue is now on Issue Tracker, but Tests can't be marked cause no Button for Test.
I have already informed maintainers about this issue ;)
We have 2 Prs, both concerning bugs in staging (this one + #22166) where we have the test issue
It does not prevent from testing and marking here the result.
We can thereafter mark them RTC as that still works on issues.joomla.org
| Status | Discussion | ⇒ | Pending |
Pedantry: I think this pr should get a label PR-staging instead of PR-3.9-dev. Branch 3.9 is closed.
Could you nevertheless test it?
Unsuccessfully.
I still have button Association in edit view of admin menu item.
PHP Message: "Notice: Undefined variable: clientId in /administrator/components/com_menus/views/item/view.html.php on line 143"
Nightly build Joomla_3.9.0-beta2-dev-Development-Full_Package.zip, Saturday, 15 September 2018 02:00:02 UTC Sunday, 16 September 2018 02:00:02 UTC
Applied patches:
22175
afterwards also
22166
Damned, this has to do with a problem as the branch is wrong.
Will close this and reopen a new PR.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-16 15:47:20 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
?
|
||
joomla-cms-bot
- | Category | Administration com_associations com_menus | ⇒ | Administration com_menus |
i've tested succesfully
but can't mark it on issue tracker cause this pr is not listed