@Bakual and @infograf768 are you guys ok with this change?

I am a bit confused here.
I thought that there would be no more sample data to install at installation time in J4 (testing or else) and that only the sample data module would be used from the CPanel (for blog and multilang).

I thought that there would be no more sample data to install at installation time in J4

I thought so too, but sql files (sample_testing.sql) are still here and are constantly being updated, so I'm doing the same.
Until they are removed they should be updated.

Then I guess this PR is necessary. Not really understanding why I am asked my advice. ?

They still should be removed for 4.0. So this PR is lost work in the end.
But I don't mind what you guys do with your time ?

Then I will close it.

It would be good to know that testers should not use this sample on testing PRs.

Well, I guess that 4.0 Production leaders had a reason to leave these files in.
Therefore I would wait for @wilsonge to decide.

Basically from core perspective they are going to get removed. However there's been issues flagged by several template companies about going down the plugin approach. So I'm leaving these files here as a placeholder whilst I try and figure out how to best accomodate everybody (for example potentially if there is an installation sql file automatically installing it (where core won't have one by default) or something related)

However there's been issues flagged by several template companies about going down the plugin approach.

There is already support for a supplemental SQL file in the install app without hooking into either existing convention for sample data installation. What more is needed?

There is already support for a supplemental SQL file in the install app without hooking into either existing convention for sample data installation. What more is needed?

Nothing. That's the first I knew of this feature.

I understand that this PR is not needed.