? ? ?
avatar alikon
alikon
13 Sep 2018

Pull Request for Issue #22152 .

Summary of Changes

  • Log reset password request
  • Log reset password complete request
  • Log remind username request

Testing Instructions

see #22152

Expected result

screenshot from 2018-09-15 10-56-32

Actual result

User ??xyz-user?? registered for an account

Documentation Changes Required

?

avatar alikon alikon - open - 13 Sep 2018
avatar Sandra97
Sandra97 - comment - 13 Sep 2018

I applied the patch but I still get "User xxx registered for an account" (but I'm a terrible tester)

avatar alikon alikon - change - 13 Sep 2018
The description was changed
avatar joomla-cms-bot joomla-cms-bot - change - 13 Sep 2018
Category Administration Language & Strings Front End com_users Plugins
avatar alikon alikon - change - 13 Sep 2018
Title
[plg_actionlog_joomla] - reset password
[plg_actionlog_joomla] - reset & remind
avatar alikon alikon - edited - 13 Sep 2018
5eb9225 13 Sep 2018 avatar alikon cs
avatar alikon alikon - change - 13 Sep 2018
Labels Added: ? ?
d5a989a 13 Sep 2018 avatar alikon cs
avatar jsubri
jsubri - comment - 13 Sep 2018

Don't work for me.

echo ("view = " . $this->app->input->get('view') );
Exit;
give me "login" not reset, remind or registration

avatar franz-wohlkoenig franz-wohlkoenig - change - 14 Sep 2018
Status New Discussion
avatar Sandra97
Sandra97 - comment - 14 Sep 2018

I tried again but I still have the same message "User xxx registered for an account", for forgot your username as well as password.

Also, when creating an account, the actions log mentions the user consented to the Terms & Conditions but not to the privacy policy. Even if the privacy consent is stored in the Consents view, wouldn't it make sense to have it also displayed in the Action Logs?

avatar joomdonation
joomdonation - comment - 14 Sep 2018

@alikon I think you can use $task to determine the action, it's more reliable than $view

$task = JFactory::getApplication()->input->get->getCmd('task');

if ($task == 'remind.remind')
{
	// Log require remind username action
}
elseif($task == 'reset.request')
{
	// Log require reset password action
}
elseif($task == 'reset.complete')
{
	// Log reset password action
}

With that said, reset password will require 2 separate action logs: One for reset request and one for actual reset password action.

@Sandra97 For logging user consented to the Terms & Conditions action, would you mind open a separate issue for it?

avatar Sandra97
Sandra97 - comment - 14 Sep 2018
avatar alikon alikon - change - 15 Sep 2018
The description was changed
avatar alikon alikon - edited - 15 Sep 2018
avatar alikon
alikon - comment - 15 Sep 2018

so now we have action-logging: for reset request and for reset complete, (using task) as suggested by @joomdonation

avatar jsubri
jsubri - comment - 17 Sep 2018

Tested successfully on remind, reset, registration.
Can't find the usual button to mark the test completed


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22157.

avatar jsubri
jsubri - comment - 17 Sep 2018

Tested successfully on remind, reset, registration.
Can't find the usual button to mark the test completed


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22157.

avatar alikon
alikon - comment - 19 Sep 2018

please re-test as a new event onUserAfterRemind has been added as requested

avatar jsubri
jsubri - comment - 19 Sep 2018

Tested successfully on 3.9.0 beta2 with the commits above
screen shot 2018-09-19 at 20 45 19


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22157.

avatar Sandra97
Sandra97 - comment - 20 Sep 2018

It works for me too
index

avatar jsubri
jsubri - comment - 21 Sep 2018

RTC, recent commits are cs only

avatar Quy Quy - change - 21 Sep 2018
Status Discussion Ready to Commit
avatar Quy
Quy - comment - 21 Sep 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22157.

avatar mbabker mbabker - change - 22 Sep 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-09-22 15:13:26
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 22 Sep 2018
avatar mbabker mbabker - merge - 22 Sep 2018

Add a Comment

Login with GitHub to post a comment