?
avatar joeforjoomla
joeforjoomla
11 Sep 2018

Steps to reproduce the issue

Open the com_privacy consents view after having unpublished the plugin 'System - Privacy Consent'

Expected result

All given consents are shown correctly

Actual result

The subject field PLG_SYSTEM_PRIVACYCONSENT_SUBJECT is not translated.

image

System information (as much as possible)

Joomla 3.9 Beta

Additional comments

avatar joeforjoomla joeforjoomla - open - 11 Sep 2018
avatar joomla-cms-bot joomla-cms-bot - change - 11 Sep 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 11 Sep 2018
avatar mbabker
mbabker - comment - 11 Sep 2018

Without making the consent keys part of a language file that is arbitrarily loaded on every request (i.e. en-GB.ini), this is going to happen. I think this ends up as a "won't fix" unless we store enough data with the consents to be able to arbitrarily load language files and not rely on something external having loaded the right one(s).

avatar joeforjoomla
joeforjoomla - comment - 11 Sep 2018

Being a language string of the com_privacy should not be supposed to move or copy the constant
PLG_SYSTEM_PRIVACYCONSENT_SUBJECT="Privacy Policy"
into the file:
/Joomla39/administrator/language/en-GB/en-GB.com_privacy.ini

I would expect to be natural to have that string in that file not loaded in the plugin file:
/Joomla39/administrator/language/en-GB/en-GB.plg_system_privacyconsent.ini

avatar mbabker
mbabker - comment - 11 Sep 2018

Even if you move that key to “fix” this for core, it doesn’t do anything to
address similar uses in potential addon plugins. So moving the key in core
might hide the problem in this specific scenario but it definitely doesn’t
fix the underlying problem.

On Tue, Sep 11, 2018 at 5:33 PM JoeforJoomla Boy notifications@github.com
wrote:

Being a language string of the com_privacy should not be supposed to move
or copy the constant
PLG_SYSTEM_PRIVACYCONSENT_SUBJECT="Privacy Policy"
into the file:
/Joomla39/administrator/language/en-GB/en-GB.com_privacy.ini


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#22136 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfoRP_XtyT5yqKza1rHjumArRujgjFks5uaDo9gaJpZM4WkMCc
.

--

  • Michael Please pardon any errors, this message was sent from my iPhone.
avatar joeforjoomla
joeforjoomla - comment - 11 Sep 2018

Well yes, at least for the 'main' and 'core' component... that would fix the problem.

avatar joeforjoomla joeforjoomla - change - 11 Sep 2018
Status New Closed
Closed_Date 0000-00-00 00:00:00 2018-09-11 22:59:23
Closed_By joeforjoomla
avatar joeforjoomla joeforjoomla - close - 11 Sep 2018
avatar joeforjoomla
joeforjoomla - comment - 11 Sep 2018

CLOSED as won't fix,

Add a Comment

Login with GitHub to post a comment