This is unsufficient.
Refreshing the help server field will re-add the french help site into j.

At the time, I added the url in https://update.joomla.org/helpsites/helpsites.xml and it is called by the Refresh button though the gethelpsites() method in UsersControllerProfile_Base_Json used by the helpsite.js

Therefore, all these should be taken off as the refresh button would now be obsolete

Now, I wish someone makes sure that, after removing all these, a Joomla installed site using the French help site (Globally or per user) will get the official help site by default.

It works as expected.
I presume the dropdown can be then removed.
And what about the Refresh button? (honestly I don't even know what action this button is performing)

@Sandra97
Look at my comment above...

Thanks Jean-Marie! Your comment was not displayed when I wrote mine.

If french is the only language that ever provided a help server then the entire option should be removed and the option to select it in the user profile and the my profile screens

@infograf768 the issue about "updating" the reference on french sites is an important one especially as the help site could be set per user. However if we remove all the code related to checking which help server to use from everywhere then even though the database record would still contain the reference it would never be used. Just a suggestion

At the time, I added the url in https://update.joomla.org/helpsites/helpsites.xml and it is called by the Refresh button though the gethelpsites() method in UsersControllerProfile_Base_Json used by the helpsite.js

Someone make sure https://github.com/joomla/update.joomla.org gets updated then whenever the time is right.

Before taking everything away from 3.9, a few remarks.
(For info: The setting may have been used even when the site was not "purely" a French site.)

1. Not sure that taking off the url is enough when the setting is set per user. It may cause an error when this user is loading the customised help as the url is in the db.
   I guess we could create an update.sql. something like

UPDATE `#__users` SET `params` = REPLACE(`params`, '"helpsite":"https:\\/\\/help.joomla.fr\\/index.php?option=com_help&keyref=Help{major}{minor}:{keyref}"', '"helpsite":""'); 

@alikon Would that be OK for the other dbs? I tested here on sqli and it works fine

2. We also have to update the local helpsites.xml when updating J. (this PR here)

3. @mbabker updating then the https://github.com/joomla/update.joomla.org/blob/master/www/helpsites/helpsites.xml would be enough?
   Is it not going to create issues for users still using < 3.9.0 sites

If it behaves the way you say it does (never used that functionality, so not a clue) if someone on a Joomla version before 3.9 used the refresh function then they would get the updated file without the French site. Which wouldn't be a problem. The important thing is going to be that the resource is there and serves a valid list of options for all versions which support reading from it (and I would really rather not introduce version conditional behavior to fetch a different XML file).

If it behaves the way you say it does (never used that functionality, so not a clue) if someone on a Joomla version before 3.9 used the refresh function then they would get the updated file without the French site.

then I guess it would be OK. I wonder if, for 3.9, we should keep the field and field type (wherever it is used) + deprecate the related ini strings + all related stuff except the code which loads the default official helpurl.
Grep gives me

/Applications/MAMP/htdocs/stagingcms/administrator/components/com_admin/models/forms/profile.xml:147: 				name="helpsite"
/Applications/MAMP/htdocs/stagingcms/administrator/components/com_admin/models/forms/profile.xml:148: 				type="helpsite"
/Applications/MAMP/htdocs/stagingcms/administrator/components/com_admin/models/forms/profile.xml:149: 				label="COM_ADMIN_USER_FIELD_HELPSITE_LABEL"
/Applications/MAMP/htdocs/stagingcms/administrator/components/com_admin/models/forms/profile.xml:150: 				description="COM_ADMIN_USER_FIELD_HELPSITE_DESC"
/Applications/MAMP/htdocs/stagingcms/administrator/components/com_config/model/form/application.xml:1199: 			type="helpsite"
/Applications/MAMP/htdocs/stagingcms/administrator/components/com_users/models/forms/user.xml:205: 				name="helpsite"
/Applications/MAMP/htdocs/stagingcms/administrator/components/com_users/models/forms/user.xml:206: 				type="helpsite"
/Applications/MAMP/htdocs/stagingcms/administrator/components/com_users/models/forms/user.xml:207: 				label="COM_USERS_USER_FIELD_HELPSITE_LABEL"
/Applications/MAMP/htdocs/stagingcms/administrator/components/com_users/models/forms/user.xml:208: 				description="COM_USERS_USER_FIELD_HELPSITE_DESC"
/Applications/MAMP/htdocs/stagingcms/components/com_users/models/forms/frontend_admin.xml:29: 				name="helpsite"
/Applications/MAMP/htdocs/stagingcms/components/com_users/models/forms/frontend_admin.xml:30: 				type="helpsite"
/Applications/MAMP/htdocs/stagingcms/components/com_users/models/forms/frontend_admin.xml:31: 				label="COM_USERS_USER_FIELD_HELPSITE_LABEL"
/Applications/MAMP/htdocs/stagingcms/components/com_users/models/forms/frontend_admin.xml:32: 				description="COM_USERS_USER_FIELD_HELPSITE_DESC"
/Applications/MAMP/htdocs/stagingcms/tests/unit/suites/libraries/joomla/utilities/stubs/test.xml:3713: 			<value>{&quot;admin_language&quot;:&quot;&quot;,&quot;language&quot;:&quot;&quot;,&quot;editor&quot;:&quot;&quot;,&quot;helpsite&quot;:&quot;&quot;,&quot;timezone&quot;:&quot;&quot;}</value>
/Applications/MAMP/htdocs/stagingcms/tests/unit/suites/libraries/joomla/utilities/stubs/test.xml:3727: 			<value>{&quot;admin_language&quot;:&quot;&quot;,&quot;language&quot;:&quot;&quot;,&quot;editor&quot;:&quot;&quot;,&quot;helpsite&quot;:&quot;&quot;,&quot;timezone&quot;:&quot;&quot;}</value>
/Applications/MAMP/htdocs/stagingcms/tests/unit/suites/libraries/joomla/utilities/stubs/test.xml:3741: 			<value>{&quot;admin_language&quot;:&quot;&quot;,&quot;language&quot;:&quot;&quot;,&quot;editor&quot;:&quot;&quot;,&quot;helpsite&quot;:&quot;&quot;,&quot;timezone&quot;:&quot;&quot;}</value>

I have asked the French joomla.fr about it and they already intended to get rid of that obsolete help site. I asked them to create a redirection.
Will keep you posted in maintainers chat.

for the query , i'd prefer to remove the helpsite key

UPDATE #__users SET "params" = REPLACE("params", '"helpsite":"https:\\/\\/help.joomla.fr\\/index.php?option=com_help&keyref=Help{major}{minor}:{keyref}"', ''); 

fine for me.

a bit of work has been done....
the code owners should decide about the helpsite field
i'm removing the field too

I have tested this item ✅ successfully on eb2275a

Help Server field not displayed anymore in the system tab, help screens work as expected, whatever is the backend language.
Thanks a lot @alikon

We do not need anymore https://github.com/joomla/joomla-cms/blob/staging/installation/localise.xml#L4

And also therefore the related code in
/installation/application/web.php

Concerning @wilsonge comment in #22133 (comment)

Is there any need to keep this file too? and not just hardcode everything back to the help proxy?

My thought is that we should keep the file and even pick up the url from it in the new installation process as, in the future, we may need to change that url and it would be easier to just modify that file.

What do you think?

me ?
hardcoded or not we should have only one place to get the only 1 official helpsite url

from my search
we should remove or deprecate ?
https://github.com/joomla/joomla-cms/blob/staging/components/com_users/helpers/html/users.php#L69

plus
just discovered some css fix

and really don't konw how to manage https://github.com/alikon/joomla-cms/blob/patch-69/administrator/templates/isis/less/blocks/_custom.less#L175

i'm not at all a frontend guy , sorry ?

for the css they first have to be deleted from the .less files and then running cli php build/generatecss.php
files concerned are
/administrator/templates/isis/less/blocks/_custom.less
and
/templates/protostar/less/template.less

hardcoded or not we should have only one place to get the only 1 official helpsite url

Let's get it then from the helpsites.xml and take off the hardcoding in installation.

I have tested this item ✅ successfully on b376fbd

Deprecate string JGLOBAL_HELPREFRESH_BUTTON in
\administrator\language\en-GB\en-GB.ini
\language\en-GB\en-GB.ini

What's the status of this?

from my POV should be ok, as stated before we need 2 successful test

I have tested this item ✅ successfully on b34c9a4

we have not deleted but deprecated libraries/src/Form/Field/HelpsiteField.php

my bad ?

@alikon whats the state of this Pull Request?

This is a b/c break and wouldn't go into J3, if @alikon wants to remove this feature it has to go into j4

I’d say taking a help screen server out of the supported list hardly counts
as a B/C break. The PHP API has been adequately addressed with this PR
without removing feature support.

On Fri, Apr 26, 2019 at 7:43 AM Harald notifications@github.com wrote:

This is a b/c break and wouldn't go into J3, if @alikon
https://github.com/alikon wants to remove this feature it has to go
into j4

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#22133 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACZ7IM2IHDIMSZMOFSCYFLPSL2F7ANCNFSM4FUPQ2SA
.

--

• Michael Please pardon any errors, this message was sent from my iPhone.

@franz-wohlkoenig for me this just need conflict fixed
but first want to listen a final word if this can go on 3.x or not

@alikon Release Lead say this have to go in J4.

well then i can only respectfully disagree

So we continue to provide French users Help Screens from an apparently abandoned site which has not been updated since 2013 (Joomla 3.2)?

Pull request opened as per decision of the Production Department.

close for #24927