[#22088] - [3.9][plugin][privacyconsent] - proper quote with dateAdd()
- Fixed in Code Base
- 9 Sep 2018
- Medium
- Build: 3.9-dev
- # 22088
- Diff
- alikon:patch-112
User tests: Successful: Unsuccessful:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
well you can find more on #21844 discussion,
https://github.com/joomla/joomla-cms/blob/3.9-dev/libraries/joomla/database/query.php#L1770
@alikon thanks! Can you add the one on line 620 as well of the same file, and the one in public_html/modules/mod_tags_popular/helper.php. I do think we have covered them all with that :-)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22088.
| Labels |
Added:
?
|
||
| Category | Front End Plugins | ⇒ | Modules Front End Plugins |
done
I have tested this item
@alikon great, thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22088.
Note: it seems that here too a quote is missing
File: ...\plugins\system\privacyconsent\privacyconsent.php
See line 618, ->where($query->dateAdd($now, $period, 'DAY') . ' > ' . $db->quoteName('created'))
See also issue #22079
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22088.
has been quoted with this PR
has been quoted with this PR
Oops, I see, in 39c25c7 8 Sep 2018
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22088.
mbabker
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-09 17:08:20 |
| Closed_By | ⇒ | mbabker |
@alikon was not sure if the dateAdd function should return the date quoted by default? If we solve it this way I suggest fixing this for all dateAdd usages and not just this one :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22088.