? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
8 Sep 2018

Add CSS Variable polyfill to Atum https://github.com/jhildenbiddle/css-vars-ponyfill

This allows us to use CSS Variables in IE11

Testing Instructions

When logged into Atum note that the CSS Vars library is now in the element of the page

avatar wilsonge wilsonge - open - 8 Sep 2018
avatar wilsonge wilsonge - change - 8 Sep 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Sep 2018
Category Administration Templates (admin) Repository
avatar wilsonge wilsonge - change - 8 Sep 2018
Title
[4.0] CSS Var Polyfill
[4.0] Add CSS Var Polyfill
avatar wilsonge wilsonge - edited - 8 Sep 2018
avatar wilsonge wilsonge - change - 8 Sep 2018
Labels Added: ?
avatar wilsonge wilsonge - change - 8 Sep 2018
The description was changed
avatar wilsonge wilsonge - edited - 8 Sep 2018
avatar brianteeman
brianteeman - comment - 8 Sep 2018

Shouldn't this be conditionally loaded only on the browsers that need it?

jhildenbiddle/css-vars-ponyfill#21

avatar wilsonge
wilsonge - comment - 8 Sep 2018

We can do it in JS that way for sure (although not sure what the effects are on poor networks) - I assume that evaluation of CSS Var support is probably OK? But it's going to be included on the page async which could mean in poor networks the colors and more importantly break points that are CSS vars could be delayed loading.

We can also try server side sniffing - but of course real browsers can be masked by proxies (and given the majority of IE users these days are in corporates on proxies it can be problematic).

avatar wilsonge
wilsonge - comment - 9 Sep 2018

Closing in favour of a concrete implementation at #22100

avatar wilsonge wilsonge - change - 9 Sep 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-09-09 12:41:07
Closed_By wilsonge
avatar wilsonge wilsonge - close - 9 Sep 2018

Add a Comment

Login with GitHub to post a comment