Feeling Lucky
?
[#22080] - [4.0] Depreciation Method Changes Requeset JLoader::register to JLoader::registerNamespace
- Closed
- 8 Sep 2018
- Medium
- Build: 4.0-dev
- # 22080
- Diff
- Didldu-Florian:patch-4
- Pending Hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Changed deprecated JLoader::register('ContentHelperRoute') first to new JLoader::registerNamespace
Testing Instructions
A few samples would be suffice enough for example in mod_articles_category, mod_articles_latest etc..
Test article links also with com_config SEF ON and OFF
Links should be valide SEF or absolute!
Documentation Changes Required
No
Additional comments
If all checks have been passed, any JLoader::register methode can be changed at next PR ;)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_categories com_content Front End com_contact com_search Modules Plugins |
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-08 16:08:59 |
| Closed_By | ⇒ | Didldu-Florian |
JLoader::register()andJLoader::registerNamespace()actually have two different purposes.The first one registers a specific class in a specific file to the autoloader.
The second one registers a PHP namespace and its root path to the autoloader (and inherently all classes within it).
Also, there is a desired end goal of these calls not being needed at all for the core extensions at least as everything is moved to namespaces and we support autoloading of all extension files (still some work to be done for some classes, like this
ContentHelperRouteclass).So as is, this pull request actually breaks things because it's an incorrect change. And the correct change would be to remove the
JLoadercalls completely once the route helper classes support being in a namespace.