Success

User tests: Successful: Unsuccessful:

avatar Achal-Aggarwal
Achal-Aggarwal
10 Oct 2013
avatar Achal-Aggarwal Achal-Aggarwal - open - 10 Oct 2013
avatar mbabker
mbabker - comment - 11 Oct 2013

I'm not seeing where validate-jquery-uncompressed.js file is being loaded up by the CMS. Where is it supposed to be used?

avatar Achal-Aggarwal
Achal-Aggarwal - comment - 11 Oct 2013

I didn't compressed it. Actually it is validate.js which needs modification. I just need to add $el.attr('required') ORed with $el.hasClass('required') so as to support current implementation and bwc.

avatar mbabker
mbabker - comment - 11 Oct 2013

So if I'm understanding right, the contents of validate-jquery-uncompressed.js should replace validate-uncompressed.js and that be compressed to replace what's in validate.js right now, right? From the looks of things, validate.js and validate-uncompressed.js are still the old version of that while the -jquery file is the one worked on for GSoC.

avatar Achal-Aggarwal
Achal-Aggarwal - comment - 11 Oct 2013

Yes. Ashan added that jquery version of validate.js. But there were some performance improvement fixes on mootools version.

avatar mbabker
mbabker - comment - 11 Oct 2013

Through the next few days then, I suggest we get those performance fixes into the jQuery file and get that cleanup taken care of.

avatar Achal-Aggarwal
Achal-Aggarwal - comment - 13 Oct 2013

Here is the new PR.
#2233

I added precomputation of labels in jQuery version as proposed in
#798

I am closing this one.

avatar Achal-Aggarwal Achal-Aggarwal - close - 13 Oct 2013

Add a Comment

Login with GitHub to post a comment